Skip to content

Commit 9848366

Browse files
Pei Xiaobroonie
authored andcommitted
spi: mpc52xx: Add cancel_work_sync before module remove
If we remove the module which will call mpc52xx_spi_remove it will free 'ms' through spi_unregister_controller. while the work ms->work will be used. The sequence of operations that may lead to a UAF bug. Fix it by ensuring that the work is canceled before proceeding with the cleanup in mpc52xx_spi_remove. Fixes: ca632f5 ("spi: reorganize drivers") Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn> Link: https://patch.msgid.link/1f16f8ae0e50ca9adb1dc849bf2ac65a40c9ceb9.1732783000.git.xiaopei01@kylinos.cn Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 40384c8 commit 9848366

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/spi/spi-mpc52xx.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -520,6 +520,7 @@ static void mpc52xx_spi_remove(struct platform_device *op)
520520
struct mpc52xx_spi *ms = spi_controller_get_devdata(host);
521521
int i;
522522

523+
cancel_work_sync(&ms->work);
523524
free_irq(ms->irq0, ms);
524525
free_irq(ms->irq1, ms);
525526

0 commit comments

Comments
 (0)