Skip to content

Commit 966cc17

Browse files
dhowellsSteve French
authored andcommitted
cifs: Share server EOF pos with netfslib
Use cifsi->netfs_ctx.remote_i_size instead of cifsi->server_eof so that netfslib can refer to it to. Signed-off-by: David Howells <dhowells@redhat.com> cc: Shyam Prasad N <nspmangalore@gmail.com> cc: Rohith Surabattula <rohiths.msft@gmail.com> cc: Jeff Layton <jlayton@kernel.org> cc: linux-cifs@vger.kernel.org cc: linux-cachefs@redhat.com cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 8deb05c commit 966cc17

File tree

6 files changed

+37
-17
lines changed

6 files changed

+37
-17
lines changed

fs/smb/client/cifsfs.c

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ cifs_alloc_inode(struct super_block *sb)
396396
spin_lock_init(&cifs_inode->writers_lock);
397397
cifs_inode->writers = 0;
398398
cifs_inode->netfs.inode.i_blkbits = 14; /* 2**14 = CIFS_MAX_MSGSIZE */
399-
cifs_inode->server_eof = 0;
399+
cifs_inode->netfs.remote_i_size = 0;
400400
cifs_inode->uniqueid = 0;
401401
cifs_inode->createtime = 0;
402402
cifs_inode->epoch = 0;
@@ -1380,6 +1380,7 @@ ssize_t cifs_file_copychunk_range(unsigned int xid,
13801380
struct inode *src_inode = file_inode(src_file);
13811381
struct inode *target_inode = file_inode(dst_file);
13821382
struct cifsInodeInfo *src_cifsi = CIFS_I(src_inode);
1383+
struct cifsInodeInfo *target_cifsi = CIFS_I(target_inode);
13831384
struct cifsFileInfo *smb_file_src;
13841385
struct cifsFileInfo *smb_file_target;
13851386
struct cifs_tcon *src_tcon;
@@ -1428,7 +1429,7 @@ ssize_t cifs_file_copychunk_range(unsigned int xid,
14281429
* Advance the EOF marker after the flush above to the end of the range
14291430
* if it's short of that.
14301431
*/
1431-
if (src_cifsi->server_eof < off + len) {
1432+
if (src_cifsi->netfs.remote_i_size < off + len) {
14321433
rc = cifs_precopy_set_eof(src_inode, src_cifsi, src_tcon, xid, off + len);
14331434
if (rc < 0)
14341435
goto unlock;
@@ -1452,12 +1453,22 @@ ssize_t cifs_file_copychunk_range(unsigned int xid,
14521453
/* Discard all the folios that overlap the destination region. */
14531454
truncate_inode_pages_range(&target_inode->i_data, fstart, fend);
14541455

1456+
fscache_invalidate(cifs_inode_cookie(target_inode), NULL,
1457+
i_size_read(target_inode), 0);
1458+
14551459
rc = file_modified(dst_file);
14561460
if (!rc) {
14571461
rc = target_tcon->ses->server->ops->copychunk_range(xid,
14581462
smb_file_src, smb_file_target, off, len, destoff);
1459-
if (rc > 0 && destoff + rc > i_size_read(target_inode))
1463+
if (rc > 0 && destoff + rc > i_size_read(target_inode)) {
14601464
truncate_setsize(target_inode, destoff + rc);
1465+
netfs_resize_file(&target_cifsi->netfs,
1466+
i_size_read(target_inode), true);
1467+
fscache_resize_cookie(cifs_inode_cookie(target_inode),
1468+
i_size_read(target_inode));
1469+
}
1470+
if (rc > 0 && destoff + rc > target_cifsi->netfs.zero_point)
1471+
target_cifsi->netfs.zero_point = destoff + rc;
14611472
}
14621473

14631474
file_accessed(src_file);

fs/smb/client/cifsglob.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1561,7 +1561,6 @@ struct cifsInodeInfo {
15611561
spinlock_t writers_lock;
15621562
unsigned int writers; /* Number of writers on this inode */
15631563
unsigned long time; /* jiffies of last update of inode */
1564-
u64 server_eof; /* current file size on server -- protected by i_lock */
15651564
u64 uniqueid; /* server inode number */
15661565
u64 createtime; /* creation time on server */
15671566
__u8 lease_key[SMB2_LEASE_KEY_SIZE]; /* lease key for this inode */

fs/smb/client/file.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2120,8 +2120,8 @@ cifs_update_eof(struct cifsInodeInfo *cifsi, loff_t offset,
21202120
{
21212121
loff_t end_of_write = offset + bytes_written;
21222122

2123-
if (end_of_write > cifsi->server_eof)
2124-
cifsi->server_eof = end_of_write;
2123+
if (end_of_write > cifsi->netfs.remote_i_size)
2124+
netfs_resize_file(&cifsi->netfs, end_of_write, true);
21252125
}
21262126

21272127
static ssize_t
@@ -3247,8 +3247,8 @@ cifs_uncached_writev_complete(struct work_struct *work)
32473247

32483248
spin_lock(&inode->i_lock);
32493249
cifs_update_eof(cifsi, wdata->offset, wdata->bytes);
3250-
if (cifsi->server_eof > inode->i_size)
3251-
i_size_write(inode, cifsi->server_eof);
3250+
if (cifsi->netfs.remote_i_size > inode->i_size)
3251+
i_size_write(inode, cifsi->netfs.remote_i_size);
32523252
spin_unlock(&inode->i_lock);
32533253

32543254
complete(&wdata->done);

fs/smb/client/inode.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ cifs_revalidate_cache(struct inode *inode, struct cifs_fattr *fattr)
104104
fattr->cf_mtime = timestamp_truncate(fattr->cf_mtime, inode);
105105
mtime = inode_get_mtime(inode);
106106
if (timespec64_equal(&mtime, &fattr->cf_mtime) &&
107-
cifs_i->server_eof == fattr->cf_eof) {
107+
cifs_i->netfs.remote_i_size == fattr->cf_eof) {
108108
cifs_dbg(FYI, "%s: inode %llu is unchanged\n",
109109
__func__, cifs_i->uniqueid);
110110
return;
@@ -194,7 +194,7 @@ cifs_fattr_to_inode(struct inode *inode, struct cifs_fattr *fattr)
194194
else
195195
clear_bit(CIFS_INO_DELETE_PENDING, &cifs_i->flags);
196196

197-
cifs_i->server_eof = fattr->cf_eof;
197+
cifs_i->netfs.remote_i_size = fattr->cf_eof;
198198
/*
199199
* Can't safely change the file size here if the client is writing to
200200
* it due to potential races.
@@ -2858,7 +2858,7 @@ cifs_set_file_size(struct inode *inode, struct iattr *attrs,
28582858

28592859
set_size_out:
28602860
if (rc == 0) {
2861-
cifsInode->server_eof = attrs->ia_size;
2861+
netfs_resize_file(&cifsInode->netfs, attrs->ia_size, true);
28622862
cifs_setsize(inode, attrs->ia_size);
28632863
/*
28642864
* i_blocks is not related to (i_size / i_blksize), but instead
@@ -3011,6 +3011,7 @@ cifs_setattr_unix(struct dentry *direntry, struct iattr *attrs)
30113011
if ((attrs->ia_valid & ATTR_SIZE) &&
30123012
attrs->ia_size != i_size_read(inode)) {
30133013
truncate_setsize(inode, attrs->ia_size);
3014+
netfs_resize_file(&cifsInode->netfs, attrs->ia_size, true);
30143015
fscache_resize_cookie(cifs_inode_cookie(inode), attrs->ia_size);
30153016
}
30163017

@@ -3210,6 +3211,7 @@ cifs_setattr_nounix(struct dentry *direntry, struct iattr *attrs)
32103211
if ((attrs->ia_valid & ATTR_SIZE) &&
32113212
attrs->ia_size != i_size_read(inode)) {
32123213
truncate_setsize(inode, attrs->ia_size);
3214+
netfs_resize_file(&cifsInode->netfs, attrs->ia_size, true);
32133215
fscache_resize_cookie(cifs_inode_cookie(inode), attrs->ia_size);
32143216
}
32153217

fs/smb/client/readdir.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ cifs_prime_dcache(struct dentry *parent, struct qstr *name,
141141
if (likely(reparse_inode_match(inode, fattr))) {
142142
fattr->cf_mode = inode->i_mode;
143143
fattr->cf_rdev = inode->i_rdev;
144-
fattr->cf_eof = CIFS_I(inode)->server_eof;
144+
fattr->cf_eof = CIFS_I(inode)->netfs.remote_i_size;
145145
fattr->cf_symlink_target = NULL;
146146
} else {
147147
CIFS_I(inode)->time = 0;

fs/smb/client/smb2ops.c

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3213,6 +3213,9 @@ static long smb3_zero_range(struct file *file, struct cifs_tcon *tcon,
32133213
cfile->fid.volatile_fid, cfile->pid, new_size);
32143214
if (rc >= 0) {
32153215
truncate_setsize(inode, new_size);
3216+
netfs_resize_file(&cifsi->netfs, new_size, true);
3217+
if (offset < cifsi->netfs.zero_point)
3218+
cifsi->netfs.zero_point = offset;
32163219
fscache_resize_cookie(cifs_inode_cookie(inode), new_size);
32173220
}
32183221
}
@@ -3436,7 +3439,7 @@ static long smb3_simple_falloc(struct file *file, struct cifs_tcon *tcon,
34363439
rc = SMB2_set_eof(xid, tcon, cfile->fid.persistent_fid,
34373440
cfile->fid.volatile_fid, cfile->pid, new_eof);
34383441
if (rc == 0) {
3439-
cifsi->server_eof = new_eof;
3442+
netfs_resize_file(&cifsi->netfs, new_eof, true);
34403443
cifs_setsize(inode, new_eof);
34413444
cifs_truncate_page(inode->i_mapping, inode->i_size);
34423445
truncate_setsize(inode, new_eof);
@@ -3528,8 +3531,9 @@ static long smb3_collapse_range(struct file *file, struct cifs_tcon *tcon,
35283531
int rc;
35293532
unsigned int xid;
35303533
struct inode *inode = file_inode(file);
3531-
struct cifsFileInfo *cfile = file->private_data;
35323534
struct cifsInodeInfo *cifsi = CIFS_I(inode);
3535+
struct cifsFileInfo *cfile = file->private_data;
3536+
struct netfs_inode *ictx = &cifsi->netfs;
35333537
loff_t old_eof, new_eof;
35343538

35353539
xid = get_xid();
@@ -3549,6 +3553,7 @@ static long smb3_collapse_range(struct file *file, struct cifs_tcon *tcon,
35493553
goto out_2;
35503554

35513555
truncate_pagecache_range(inode, off, old_eof);
3556+
ictx->zero_point = old_eof;
35523557

35533558
rc = smb2_copychunk_range(xid, cfile, cfile, off + len,
35543559
old_eof - off - len, off);
@@ -3563,9 +3568,10 @@ static long smb3_collapse_range(struct file *file, struct cifs_tcon *tcon,
35633568

35643569
rc = 0;
35653570

3566-
cifsi->server_eof = i_size_read(inode) - len;
3567-
truncate_setsize(inode, cifsi->server_eof);
3568-
fscache_resize_cookie(cifs_inode_cookie(inode), cifsi->server_eof);
3571+
truncate_setsize(inode, new_eof);
3572+
netfs_resize_file(&cifsi->netfs, new_eof, true);
3573+
ictx->zero_point = new_eof;
3574+
fscache_resize_cookie(cifs_inode_cookie(inode), new_eof);
35693575
out_2:
35703576
filemap_invalidate_unlock(inode->i_mapping);
35713577
out:
@@ -3581,6 +3587,7 @@ static long smb3_insert_range(struct file *file, struct cifs_tcon *tcon,
35813587
unsigned int xid;
35823588
struct cifsFileInfo *cfile = file->private_data;
35833589
struct inode *inode = file_inode(file);
3590+
struct cifsInodeInfo *cifsi = CIFS_I(inode);
35843591
__u64 count, old_eof, new_eof;
35853592

35863593
xid = get_xid();
@@ -3608,6 +3615,7 @@ static long smb3_insert_range(struct file *file, struct cifs_tcon *tcon,
36083615
goto out_2;
36093616

36103617
truncate_setsize(inode, new_eof);
3618+
netfs_resize_file(&cifsi->netfs, i_size_read(inode), true);
36113619
fscache_resize_cookie(cifs_inode_cookie(inode), i_size_read(inode));
36123620

36133621
rc = smb2_copychunk_range(xid, cfile, cfile, off, count, off + len);

0 commit comments

Comments
 (0)