Skip to content

Commit 956578e

Browse files
ruanjinjiejonmason
authored andcommitted
NTB: EPF: fix possible memory leak in pci_vntb_probe()
As ntb_register_device() don't handle error of device_register(), if ntb_register_device() returns error in pci_vntb_probe(), name of kobject which is allocated in dev_set_name() called in device_add() is leaked. As comment of device_add() says, it should call put_device() to drop the reference count that was set in device_initialize() when it fails, so the name can be freed in kobject_cleanup(). Signed-off-by: ruanjinjie <ruanjinjie@huawei.com> Signed-off-by: Jon Mason <jdmason@kudzu.us>
1 parent 2790143 commit 956578e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/pci/endpoint/functions/pci-epf-vntb.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1285,6 +1285,7 @@ static int pci_vntb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
12851285
return 0;
12861286

12871287
err_register_dev:
1288+
put_device(&ndev->ntb.dev);
12881289
return -EINVAL;
12891290
}
12901291

0 commit comments

Comments
 (0)