Skip to content

Commit 94565e9

Browse files
drm/ssd130x: Fix possible uninitialized usage of crtc_state variable
Avoid a possible uninitialized use of the crtc_state variable in function ssd132x_primary_plane_atomic_check() and avoid the following Smatch warn: drivers/gpu/drm/solomon/ssd130x.c:921 ssd132x_primary_plane_atomic_check() error: uninitialized symbol 'crtc_state'. Fixes: fdd591e ("drm/ssd130x: Add support for the SSD132x OLED controller family") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/dri-devel/7dd6ca45-8263-44fe-a318-2fd9d761425d@moroto.mountain/ Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by: Jocelyn Falempe <jfalempe@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231020225338.1686974-1-javierm@redhat.com (cherry picked from commit 9e4db19) Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
1 parent a49cf37 commit 94565e9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/solomon/ssd130x.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -910,7 +910,7 @@ static int ssd132x_primary_plane_atomic_check(struct drm_plane *plane,
910910
struct drm_plane_state *plane_state = drm_atomic_get_new_plane_state(state, plane);
911911
struct ssd130x_plane_state *ssd130x_state = to_ssd130x_plane_state(plane_state);
912912
struct drm_crtc *crtc = plane_state->crtc;
913-
struct drm_crtc_state *crtc_state;
913+
struct drm_crtc_state *crtc_state = NULL;
914914
const struct drm_format_info *fi;
915915
unsigned int pitch;
916916
int ret;

0 commit comments

Comments
 (0)