Skip to content

Commit 91dda69

Browse files
tohojoAlexei Starovoitov
authored andcommitted
samples/bpf: Remove the xdp_redirect* utilities
These utilities have all been ported to xdp-tools as functions of the xdp-bench utility. The four different utilities in samples are incorporated as separate subcommands to xdp-bench, with most of the command line parameters left intact, except that mandatory arguments are always positional in xdp-bench. For full usage details see the --help output of each command, or the xdp-bench man page. Some examples of how to convert usage to xdp-bench are: xdp_redirect eth0 eth1 --> xdp-bench redirect eth0 eth1 xdp_redirect_map eth0 eth1 --> xdp-bench redirect-map eth0 eth1 xdp_redirect_map_multi eth0 eth1 eth2 eth3 --> xdp-bench redirect-multi eth0 eth1 eth2 eth3 xdp_redirect_cpu -d eth0 -c 0 -c 1 --> xdp-bench redirect-cpu -c 0 -c 1 eth0 xdp_redirect_cpu -d eth0 -c 0 -c 1 -r eth1 --> xdp-bench redirect-cpu -c 0 -c 1 eth0 -r redirect -D eth1 Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com> Link: https://lore.kernel.org/r/20230824102255.1561885-3-toke@redhat.com Signed-off-by: Alexei Starovoitov <ast@kernel.org>
1 parent e7c9e73 commit 91dda69

9 files changed

+1
-1981
lines changed

samples/bpf/Makefile

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,6 @@ tprogs-y += xdp_sample_pkts
5151
tprogs-y += ibumad
5252
tprogs-y += hbm
5353

54-
tprogs-y += xdp_redirect_cpu
55-
tprogs-y += xdp_redirect_map_multi
56-
tprogs-y += xdp_redirect_map
57-
tprogs-y += xdp_redirect
58-
5954
# Libbpf dependencies
6055
LIBBPF_SRC = $(TOOLS_PATH)/lib/bpf
6156
LIBBPF_OUTPUT = $(abspath $(BPF_SAMPLES_PATH))/libbpf
@@ -111,10 +106,6 @@ xdp_sample_pkts-objs := xdp_sample_pkts_user.o
111106
ibumad-objs := ibumad_user.o
112107
hbm-objs := hbm.o $(CGROUP_HELPERS)
113108

114-
xdp_redirect_map_multi-objs := xdp_redirect_map_multi_user.o $(XDP_SAMPLE)
115-
xdp_redirect_cpu-objs := xdp_redirect_cpu_user.o $(XDP_SAMPLE)
116-
xdp_redirect_map-objs := xdp_redirect_map_user.o $(XDP_SAMPLE)
117-
xdp_redirect-objs := xdp_redirect_user.o $(XDP_SAMPLE)
118109
xdp_router_ipv4-objs := xdp_router_ipv4_user.o $(XDP_SAMPLE)
119110

120111
# Tell kbuild to always build the programs
@@ -205,10 +196,6 @@ TPROGS_LDFLAGS := -L$(SYSROOT)/usr/lib
205196
endif
206197

207198
TPROGS_LDLIBS += $(LIBBPF) -lelf -lz
208-
TPROGLDLIBS_xdp_redirect += -lm
209-
TPROGLDLIBS_xdp_redirect_cpu += -lm
210-
TPROGLDLIBS_xdp_redirect_map += -lm
211-
TPROGLDLIBS_xdp_redirect_map_multi += -lm
212199
TPROGLDLIBS_xdp_router_ipv4 += -lm -pthread
213200
TPROGLDLIBS_tracex4 += -lrt
214201
TPROGLDLIBS_trace_output += -lrt
@@ -323,10 +310,6 @@ $(obj)/$(TRACE_HELPERS) $(obj)/$(CGROUP_HELPERS) $(obj)/$(XDP_SAMPLE): | libbpf_
323310

324311
.PHONY: libbpf_hdrs
325312

326-
$(obj)/xdp_redirect_cpu_user.o: $(obj)/xdp_redirect_cpu.skel.h
327-
$(obj)/xdp_redirect_map_multi_user.o: $(obj)/xdp_redirect_map_multi.skel.h
328-
$(obj)/xdp_redirect_map_user.o: $(obj)/xdp_redirect_map.skel.h
329-
$(obj)/xdp_redirect_user.o: $(obj)/xdp_redirect.skel.h
330313
$(obj)/xdp_router_ipv4_user.o: $(obj)/xdp_router_ipv4.skel.h
331314

332315
$(obj)/tracex5.bpf.o: $(obj)/syscall_nrs.h
@@ -379,10 +362,6 @@ endef
379362

380363
CLANG_SYS_INCLUDES = $(call get_sys_includes,$(CLANG))
381364

382-
$(obj)/xdp_redirect_cpu.bpf.o: $(obj)/xdp_sample.bpf.o
383-
$(obj)/xdp_redirect_map_multi.bpf.o: $(obj)/xdp_sample.bpf.o
384-
$(obj)/xdp_redirect_map.bpf.o: $(obj)/xdp_sample.bpf.o
385-
$(obj)/xdp_redirect.bpf.o: $(obj)/xdp_sample.bpf.o
386365
$(obj)/xdp_router_ipv4.bpf.o: $(obj)/xdp_sample.bpf.o
387366

388367
$(obj)/%.bpf.o: $(src)/%.bpf.c $(obj)/vmlinux.h $(src)/xdp_sample.bpf.h $(src)/xdp_sample_shared.h
@@ -393,15 +372,9 @@ $(obj)/%.bpf.o: $(src)/%.bpf.c $(obj)/vmlinux.h $(src)/xdp_sample.bpf.h $(src)/x
393372
-I$(LIBBPF_INCLUDE) $(CLANG_SYS_INCLUDES) \
394373
-c $(filter %.bpf.c,$^) -o $@
395374

396-
LINKED_SKELS := xdp_redirect_cpu.skel.h xdp_redirect_map_multi.skel.h \
397-
xdp_redirect_map.skel.h xdp_redirect.skel.h \
398-
xdp_router_ipv4.skel.h
375+
LINKED_SKELS := xdp_router_ipv4.skel.h
399376
clean-files += $(LINKED_SKELS)
400377

401-
xdp_redirect_cpu.skel.h-deps := xdp_redirect_cpu.bpf.o xdp_sample.bpf.o
402-
xdp_redirect_map_multi.skel.h-deps := xdp_redirect_map_multi.bpf.o xdp_sample.bpf.o
403-
xdp_redirect_map.skel.h-deps := xdp_redirect_map.bpf.o xdp_sample.bpf.o
404-
xdp_redirect.skel.h-deps := xdp_redirect.bpf.o xdp_sample.bpf.o
405378
xdp_router_ipv4.skel.h-deps := xdp_router_ipv4.bpf.o xdp_sample.bpf.o
406379

407380
LINKED_BPF_SRCS := $(patsubst %.bpf.o,%.bpf.c,$(foreach skel,$(LINKED_SKELS),$($(skel)-deps)))

samples/bpf/xdp_redirect.bpf.c

Lines changed: 0 additions & 49 deletions
This file was deleted.

0 commit comments

Comments
 (0)