Skip to content

Commit 9156441

Browse files
Kostrgroeck
authored andcommitted
hwmon: (pmbus/mp2975) Correct comment inside 'mp2975_read_byte_data'
The current driver code no longer perfrom internal conversion from VID to direct. Instead it configures READ_VOUT using MFR_DC_LOOP_CTRL. Correct the comment message inside the 'mp2975_read_byte_data' function to match the driver logic. Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com> Fixes: c60fe56 ("hwmon: (pmbus/mp2975) Fix driver initialization for MP2975 device") Link: https://lore.kernel.org/r/20240127154844.989-1-aladyshev22@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent c60fe56 commit 9156441

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

drivers/hwmon/pmbus/mp2975.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,9 @@ static int mp2975_read_byte_data(struct i2c_client *client, int page, int reg)
131131
switch (reg) {
132132
case PMBUS_VOUT_MODE:
133133
/*
134-
* Enforce VOUT direct format, since device allows to set the
135-
* different formats for the different rails. Conversion from
136-
* VID to direct provided by driver internally, in case it is
137-
* necessary.
134+
* Report direct format as configured by MFR_DC_LOOP_CTRL.
135+
* Unlike on MP2971/MP2973 the reported VOUT_MODE isn't automatically
136+
* internally updated, but always reads as PB_VOUT_MODE_VID.
138137
*/
139138
return PB_VOUT_MODE_DIRECT;
140139
default:

0 commit comments

Comments
 (0)