Skip to content

Commit 9133607

Browse files
oleg-nesterovbrauner
authored andcommitted
exit: fix the usage of delay_group_leader->exit_code in do_notify_parent() and pidfs_exit()
Consider a process with a group leader L and a sub-thread T. L does sys_exit(1), then T does sys_exit_group(2). In this case wait_task_zombie(L) will notice SIGNAL_GROUP_EXIT and use L->signal->group_exit_code, this is correct. But, before that, do_notify_parent(L) called by release_task(T) will use L->exit_code != L->signal->group_exit_code, and this is not consistent. We don't really care, I think that nobody relies on the info which comes with SIGCHLD, if nothing else SIGCHLD < SIGRTMIN can be queued only once. But pidfs_exit() is more problematic, I think pidfs_exit_info->exit_code should report ->group_exit_code in this case, just like wait_task_zombie(). TODO: with this change we can hopefully cleanup (or may be even kill) the similar SIGNAL_GROUP_EXIT checks, at least in wait_task_zombie(). Signed-off-by: Oleg Nesterov <oleg@redhat.com> Link: https://lore.kernel.org/r/20250324171941.GA13114@redhat.com Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 1243045 commit 9133607

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

kernel/exit.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,9 @@ void release_task(struct task_struct *p)
268268
leader = p->group_leader;
269269
if (leader != p && thread_group_empty(leader)
270270
&& leader->exit_state == EXIT_ZOMBIE) {
271+
/* for pidfs_exit() and do_notify_parent() */
272+
if (leader->signal->flags & SIGNAL_GROUP_EXIT)
273+
leader->exit_code = leader->signal->group_exit_code;
271274
/*
272275
* If we were the last child thread and the leader has
273276
* exited already, and the leader's parent ignores SIGCHLD,

0 commit comments

Comments
 (0)