ext4: remove unused return value of ext4_mb_release

Kemeng Shi · tytso · commit 908177175a2a · 2024-01-18T10:52:45.000-05:00
Remove unused return value of ext4_mb_release. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20240105092102.496631-6-shikemeng@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
@@ -2912,7 +2912,7 @@ extern const struct seq_operations ext4_mb_seq_groups_ops;
 extern const struct seq_operations ext4_mb_seq_structs_summary_ops;
 extern int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset);
 extern int ext4_mb_init(struct super_block *);
-extern int ext4_mb_release(struct super_block *);
+extern void ext4_mb_release(struct super_block *);
 extern ext4_fsblk_t ext4_mb_new_blocks(handle_t *,
 				struct ext4_allocation_request *, int *);
 extern void ext4_discard_preallocations(struct inode *, unsigned int);
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
@@ -3750,7 +3750,7 @@ static int ext4_mb_cleanup_pa(struct ext4_group_info *grp)
 	return count;
 }
 
-int ext4_mb_release(struct super_block *sb)
+void ext4_mb_release(struct super_block *sb)
 {
 	ext4_group_t ngroups = ext4_get_groups_count(sb);
 	ext4_group_t i;
@@ -3826,8 +3826,6 @@ int ext4_mb_release(struct super_block *sb)
 	}
 
 	free_percpu(sbi->s_locality_groups);
-
-	return 0;
 }
 
 static inline int ext4_issue_discard(struct super_block *sb,

Original file line number	Diff line number	Diff line change
`@@ -3750,7 +3750,7 @@ static int ext4_mb_cleanup_pa(struct ext4_group_info *grp)`
`3750`	`3750`	`return count;`
`3751`	`3751`	`}`
`3752`	`3752`
`3753`		`-int ext4_mb_release(struct super_block *sb)`
	`3753`	`+void ext4_mb_release(struct super_block *sb)`
`3754`	`3754`	`{`
`3755`	`3755`	`ext4_group_t ngroups = ext4_get_groups_count(sb);`
`3756`	`3756`	`ext4_group_t i;`
`@@ -3826,8 +3826,6 @@ int ext4_mb_release(struct super_block *sb)`
`3826`	`3826`	`}`
`3827`	`3827`
`3828`	`3828`	`free_percpu(sbi->s_locality_groups);`
`3829`		`-`
`3830`		`- return 0;`
`3831`	`3829`	`}`
`3832`	`3830`
`3833`	`3831`	`static inline int ext4_issue_discard(struct super_block *sb,`