Skip to content

Commit 9078f01

Browse files
arndbstorulf
authored andcommitted
mmc: renesas_sdhi: add regulator dependency
The driver started using the regulator subsystem and fails to build without a dependeny on CONFIG_REGULATOR: ERROR: modpost: "rdev_get_drvdata" [drivers/mmc/host/renesas_sdhi_core.ko] undefined! ERROR: modpost: "devm_regulator_register" [drivers/mmc/host/renesas_sdhi_core.ko] undefined! The 'select RESET_CONTROLLER' needs to either go away or get changed to a dependency in order to avoid Kconfig dependency loops here. It also turns out the the superh version needs neither RESET_CONTROLLER nor REGULATOR, and this works because CONFIG_OF is not set there. Change both to a 'depends on', but add '|| !OF' for the superh case. Fixes: fae80a9 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC") Tested-by: Biju Das <biju.das.jz@bp.renesas.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Link: https://lore.kernel.org/r/20250329164145.3194284-1-arnd@kernel.org Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 649b50a commit 9078f01

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mmc/host/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -691,8 +691,8 @@ config MMC_TMIO_CORE
691691
config MMC_SDHI
692692
tristate "Renesas SDHI SD/SDIO controller support"
693693
depends on SUPERH || ARCH_RENESAS || COMPILE_TEST
694+
depends on (RESET_CONTROLLER && REGULATOR) || !OF
694695
select MMC_TMIO_CORE
695-
select RESET_CONTROLLER if ARCH_RENESAS
696696
help
697697
This provides support for the SDHI SD/SDIO controller found in
698698
Renesas SuperH, ARM and ARM64 based SoCs

0 commit comments

Comments
 (0)