Skip to content

Commit 8f6dfc4

Browse files
jannaualyssarosenzweig
authored andcommitted
drm: adp: Remove pointless irq_lock spin lock
Interrupt handlers run with interrupts disabled so it is not necessary to protect them against reentrancy. Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Signed-off-by: Janne Grunau <j@jannau.net> Link: https://lore.kernel.org/r/20250428-drm_adp_fixes-v2-4-912e081e55d8@jannau.net Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
1 parent c082a52 commit 8f6dfc4

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/gpu/drm/adp/adp_drv.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,6 @@ struct adp_drv_private {
121121
dma_addr_t mask_iova;
122122
int be_irq;
123123
int fe_irq;
124-
spinlock_t irq_lock;
125124
struct drm_pending_vblank_event *event;
126125
};
127126

@@ -490,8 +489,6 @@ static irqreturn_t adp_fe_irq(int irq, void *arg)
490489
u32 int_status;
491490
u32 int_ctl;
492491

493-
spin_lock(&adp->irq_lock);
494-
495492
int_status = readl(adp->fe + ADP_INT_STATUS);
496493
if (int_status & ADP_INT_STATUS_VBLANK) {
497494
drm_crtc_handle_vblank(&adp->crtc);
@@ -509,7 +506,6 @@ static irqreturn_t adp_fe_irq(int irq, void *arg)
509506

510507
writel(int_status, adp->fe + ADP_INT_STATUS);
511508

512-
spin_unlock(&adp->irq_lock);
513509

514510
return IRQ_HANDLED;
515511
}
@@ -574,8 +570,6 @@ static int adp_probe(struct platform_device *pdev)
574570
if (IS_ERR(adp))
575571
return PTR_ERR(adp);
576572

577-
spin_lock_init(&adp->irq_lock);
578-
579573
dev_set_drvdata(&pdev->dev, &adp->drm);
580574

581575
err = adp_parse_of(pdev, adp);

0 commit comments

Comments
 (0)