Skip to content

Commit 8f61d48

Browse files
stellarhopperdjbw
authored andcommitted
tools/testing/cxl: Slow down the mock firmware transfer
The cxl-cli unit test for firmware update does operations like starting an asynchronous firmware update, making sure it is in progress, and attempting to cancel it. In some cases, such as with no or minimal dynamic debugging turned on, the firmware update completes too quickly, not allowing the test to have a chance to verify it was in progress. This caused a failure of the signature: expected fw_update_in_progress:true test/cxl-update-firmware.sh: failed at line 88 Fix this by adding a delay (~1.5 - 2 ms) to each firmware transfer request handled by the mocked interface. Reported-by: Dan Williams <dan.j.williams@intel.com> Tested-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> Link: https://lore.kernel.org/r/20231026-vv-fw_upd_test_fix-v2-1-5282fd193883@intel.com Signed-off-by: Dan Williams <dan.j.williams@intel.com>
1 parent 98a04c7 commit 8f61d48

File tree

1 file changed

+1
-0
lines changed
  • tools/testing/cxl/test

1 file changed

+1
-0
lines changed

tools/testing/cxl/test/mem.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1270,6 +1270,7 @@ static int mock_transfer_fw(struct cxl_mockmem_data *mdata,
12701270
}
12711271

12721272
memcpy(fw + offset, transfer->data, length);
1273+
usleep_range(1500, 2000);
12731274
return 0;
12741275
}
12751276

0 commit comments

Comments
 (0)