Skip to content

Commit 8f1c517

Browse files
robherringkwilczynski
authored andcommitted
PCI: iproc: Use of_property_read_bool() for boolean properties
Replace low-level property access functions like of_get_property() and of_find_property() with their typed equivalents (i.e., of_property_read_<type> functions), as it's preferred to use typed property access functions for reading properties. [kwilczynski: commit log] Link: https://lore.kernel.org/linux-pci/20230609193326.1963542-1-robh@kernel.org Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Acked-by: Ray Jui <ray.jui@broadcom.com>
1 parent 06c2afb commit 8f1c517

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/pci/controller/pcie-iproc-msi.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ int iproc_msi_init(struct iproc_pcie *pcie, struct device_node *node)
525525
if (!of_device_is_compatible(node, "brcm,iproc-msi"))
526526
return -ENODEV;
527527

528-
if (!of_find_property(node, "msi-controller", NULL))
528+
if (!of_property_read_bool(node, "msi-controller"))
529529
return -ENODEV;
530530

531531
if (pcie->msi)
@@ -585,8 +585,7 @@ int iproc_msi_init(struct iproc_pcie *pcie, struct device_node *node)
585585
return -EINVAL;
586586
}
587587

588-
if (of_find_property(node, "brcm,pcie-msi-inten", NULL))
589-
msi->has_inten_reg = true;
588+
msi->has_inten_reg = of_property_read_bool(node, "brcm,pcie-msi-inten");
590589

591590
msi->nr_msi_vecs = msi->nr_irqs * EQ_LEN;
592591
msi->bitmap = devm_bitmap_zalloc(pcie->dev, msi->nr_msi_vecs,

0 commit comments

Comments
 (0)