Skip to content

Commit 8edd00b

Browse files
ConchuODJassi Brar
authored andcommitted
dt-bindings: mailbox: mpfs: fix reg properties
When the binding for this was originally written, and later modified, mistakes were made - and the precise nature of the later modification should have been a giveaway, but alas I was naive at the time. A more correct modelling of the hardware is to use two syscons and have a single reg entry for the mailbox, containing the mailbox region. The two syscons contain the general control/status registers for the mailbox and the interrupt related registers respectively. The reason for two syscons is that the same mailbox is present on the non-SoC version of the FPGA, which has no interrupt controller, and the shared part of the rtl was unchanged between devices. This is now coming to a head, because the control/status registers share a register region with the "tvs" (temperature & voltage sensors) registers and, as it turns out, people do want to monitor temperatures and voltages... Signed-off-by: Conor Dooley <conor.dooley@microchip.com> Acked-by: Rob Herring (Arm) <robh@kernel.org> Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
1 parent 2d5404c commit 8edd00b

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

Documentation/devicetree/bindings/mailbox/microchip,mpfs-mailbox.yaml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ properties:
1515

1616
reg:
1717
oneOf:
18+
- items:
19+
- description: mailbox data registers
1820
- items:
1921
- description: mailbox control & data registers
2022
- description: mailbox interrupt registers
@@ -23,6 +25,7 @@ properties:
2325
- description: mailbox control registers
2426
- description: mailbox interrupt registers
2527
- description: mailbox data registers
28+
deprecated: true
2629

2730
interrupts:
2831
maxItems: 1
@@ -41,12 +44,12 @@ additionalProperties: false
4144
examples:
4245
- |
4346
soc {
44-
#address-cells = <2>;
45-
#size-cells = <2>;
46-
mbox: mailbox@37020000 {
47+
#address-cells = <1>;
48+
#size-cells = <1>;
49+
50+
mailbox@37020800 {
4751
compatible = "microchip,mpfs-mailbox";
48-
reg = <0x0 0x37020000 0x0 0x58>, <0x0 0x2000318C 0x0 0x40>,
49-
<0x0 0x37020800 0x0 0x100>;
52+
reg = <0x37020800 0x100>;
5053
interrupt-parent = <&L1>;
5154
interrupts = <96>;
5255
#mbox-cells = <1>;

0 commit comments

Comments
 (0)