PCI: Free released resource after coalescing

rosslagerwall · bjorn-helgaas · commit 8ec9c1d5d0a5 · 2023-09-06T12:19:29.000-05:00
release_resource() doesn't actually free the resource or resource list entry so free the resource list entry to avoid a leak. Closes: https://lore.kernel.org/r/878r9sga1t.fsf@kernel.org/ Fixes: e542232 ("PCI: Release resource invalidated by coalescing") Link: https://lore.kernel.org/r/20230906110846.225369-1-ross.lagerwall@citrix.com Reported-by: Kalle Valo <kvalo@kernel.org> Tested-by: Kalle Valo <kvalo@kernel.org> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Cc: stable@vger.kernel.org # v5.16+
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
@@ -997,6 +997,7 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge)
 		res = window->res;
 		if (!res->flags && !res->start && !res->end) {
 			release_resource(res);
+			resource_list_destroy_entry(window);
 			continue;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -997,6 +997,7 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge)`
`997`	`997`	`res = window->res;`
`998`	`998`	`if (!res->flags && !res->start && !res->end) {`
`999`	`999`	`release_resource(res);`
	`1000`	`+ resource_list_destroy_entry(window);`
`1000`	`1001`	`continue;`
`1001`	`1002`	`}`
`1002`	`1003`