Skip to content

Commit 8e41e0a

Browse files
committed
Revert "ACPICA: Events: Support fixed PCIe wake event"
This reverts commit 5c62d5a. This broke wake-on-lan for multiple people, and for much too long. Link: https://bugzilla.kernel.org/show_bug.cgi?id=217069 Link: https://lore.kernel.org/all/754225a2-95a9-2c36-1886-7da1a78308c2@loongson.cn/ Link: acpica/acpica#866 Cc: Rafael J. Wysocki <rafael@kernel.org> Cc: Jianmin Lv <lvjianmin@loongson.cn> Cc: Huacai Chen <chenhuacai@loongson.cn> Cc: Bob Moore <robert.moore@intel.com> Cc: stable@kernel.org # 6.2 Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent c337b23 commit 8e41e0a

File tree

4 files changed

+1
-31
lines changed

4 files changed

+1
-31
lines changed

drivers/acpi/acpica/evevent.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,6 @@ static acpi_status acpi_ev_fixed_event_initialize(void)
142142
status =
143143
acpi_write_bit_register(acpi_gbl_fixed_event_info
144144
[i].enable_register_id,
145-
(i ==
146-
ACPI_EVENT_PCIE_WAKE) ?
147-
ACPI_ENABLE_EVENT :
148145
ACPI_DISABLE_EVENT);
149146
if (ACPI_FAILURE(status)) {
150147
return (status);
@@ -188,11 +185,6 @@ u32 acpi_ev_fixed_event_detect(void)
188185
return (int_status);
189186
}
190187

191-
if (fixed_enable & ACPI_BITMASK_PCIEXP_WAKE_DISABLE)
192-
fixed_enable &= ~ACPI_BITMASK_PCIEXP_WAKE_DISABLE;
193-
else
194-
fixed_enable |= ACPI_BITMASK_PCIEXP_WAKE_DISABLE;
195-
196188
ACPI_DEBUG_PRINT((ACPI_DB_INTERRUPTS,
197189
"Fixed Event Block: Enable %08X Status %08X\n",
198190
fixed_enable, fixed_status));
@@ -258,9 +250,6 @@ static u32 acpi_ev_fixed_event_dispatch(u32 event)
258250
if (!acpi_gbl_fixed_event_handlers[event].handler) {
259251
(void)acpi_write_bit_register(acpi_gbl_fixed_event_info[event].
260252
enable_register_id,
261-
(event ==
262-
ACPI_EVENT_PCIE_WAKE) ?
263-
ACPI_ENABLE_EVENT :
264253
ACPI_DISABLE_EVENT);
265254

266255
ACPI_ERROR((AE_INFO,

drivers/acpi/acpica/hwsleep.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -311,20 +311,6 @@ acpi_status acpi_hw_legacy_wake(u8 sleep_state)
311311
[ACPI_EVENT_SLEEP_BUTTON].
312312
status_register_id, ACPI_CLEAR_STATUS);
313313

314-
/* Enable pcie wake event if support */
315-
if ((acpi_gbl_FADT.flags & ACPI_FADT_PCI_EXPRESS_WAKE)) {
316-
(void)
317-
acpi_write_bit_register(acpi_gbl_fixed_event_info
318-
[ACPI_EVENT_PCIE_WAKE].
319-
enable_register_id,
320-
ACPI_DISABLE_EVENT);
321-
(void)
322-
acpi_write_bit_register(acpi_gbl_fixed_event_info
323-
[ACPI_EVENT_PCIE_WAKE].
324-
status_register_id,
325-
ACPI_CLEAR_STATUS);
326-
}
327-
328314
acpi_hw_execute_sleep_method(METHOD_PATHNAME__SST, ACPI_SST_WORKING);
329315
return_ACPI_STATUS(status);
330316
}

drivers/acpi/acpica/utglobal.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -186,10 +186,6 @@ struct acpi_fixed_event_info acpi_gbl_fixed_event_info[ACPI_NUM_FIXED_EVENTS] =
186186
ACPI_BITREG_RT_CLOCK_ENABLE,
187187
ACPI_BITMASK_RT_CLOCK_STATUS,
188188
ACPI_BITMASK_RT_CLOCK_ENABLE},
189-
/* ACPI_EVENT_PCIE_WAKE */ {ACPI_BITREG_PCIEXP_WAKE_STATUS,
190-
ACPI_BITREG_PCIEXP_WAKE_DISABLE,
191-
ACPI_BITMASK_PCIEXP_WAKE_STATUS,
192-
ACPI_BITMASK_PCIEXP_WAKE_DISABLE},
193189
};
194190
#endif /* !ACPI_REDUCED_HARDWARE */
195191

include/acpi/actypes.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -723,8 +723,7 @@ typedef u32 acpi_event_type;
723723
#define ACPI_EVENT_POWER_BUTTON 2
724724
#define ACPI_EVENT_SLEEP_BUTTON 3
725725
#define ACPI_EVENT_RTC 4
726-
#define ACPI_EVENT_PCIE_WAKE 5
727-
#define ACPI_EVENT_MAX 5
726+
#define ACPI_EVENT_MAX 4
728727
#define ACPI_NUM_FIXED_EVENTS ACPI_EVENT_MAX + 1
729728

730729
/*

0 commit comments

Comments
 (0)