Skip to content

Commit 8dd3804

Browse files
author
Kent Overstreet
committed
bcachefs: Add missing READ_ONCE() for metadata replicas
If we race with the user changing the metadata_replicas setting, this could cause us to get an incorrectly sized disk reservation. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
1 parent 72b5259 commit 8dd3804

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/bcachefs/btree_update_interior.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1221,7 +1221,7 @@ bch2_btree_update_start(struct btree_trans *trans, struct btree_path *path,
12211221

12221222
ret = bch2_disk_reservation_get(c, &as->disk_res,
12231223
(nr_nodes[0] + nr_nodes[1]) * btree_sectors(c),
1224-
c->opts.metadata_replicas,
1224+
READ_ONCE(c->opts.metadata_replicas),
12251225
disk_res_flags);
12261226
if (ret)
12271227
goto err;

0 commit comments

Comments
 (0)