Skip to content

Commit 8d99c11

Browse files
rddunlapSteve French
authored andcommitted
ksmbd: vfs: fix all kernel-doc warnings
Fix all kernel-doc warnings in vfs.c: vfs.c:54: warning: Function parameter or member 'parent' not described in 'ksmbd_vfs_lock_parent' vfs.c:54: warning: Function parameter or member 'child' not described in 'ksmbd_vfs_lock_parent' vfs.c:54: warning: No description found for return value of 'ksmbd_vfs_lock_parent' vfs.c:372: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_read' vfs.c:372: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_read' vfs.c:489: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_write' vfs.c:489: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_write' vfs.c:555: warning: Function parameter or member 'path' not described in 'ksmbd_vfs_getattr' vfs.c:555: warning: Function parameter or member 'stat' not described in 'ksmbd_vfs_getattr' vfs.c:555: warning: Excess function parameter 'work' description in 'ksmbd_vfs_getattr' vfs.c:555: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_getattr' vfs.c:555: warning: Excess function parameter 'attrs' description in 'ksmbd_vfs_getattr' vfs.c:572: warning: Function parameter or member 'p_id' not described in 'ksmbd_vfs_fsync' vfs.c:595: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_remove_file' vfs.c:595: warning: Function parameter or member 'path' not described in 'ksmbd_vfs_remove_file' vfs.c:595: warning: Excess function parameter 'name' description in 'ksmbd_vfs_remove_file' vfs.c:633: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_link' vfs.c:805: warning: Function parameter or member 'fp' not described in 'ksmbd_vfs_truncate' vfs.c:805: warning: Excess function parameter 'fid' description in 'ksmbd_vfs_truncate' vfs.c:846: warning: Excess function parameter 'size' description in 'ksmbd_vfs_listxattr' vfs.c:953: warning: Function parameter or member 'option' not described in 'ksmbd_vfs_set_fadvise' vfs.c:953: warning: Excess function parameter 'options' description in 'ksmbd_vfs_set_fadvise' vfs.c:1167: warning: Function parameter or member 'um' not described in 'ksmbd_vfs_lookup_in_dir' vfs.c:1203: warning: Function parameter or member 'work' not described in 'ksmbd_vfs_kern_path_locked' vfs.c:1641: warning: No description found for return value of 'ksmbd_vfs_init_kstat' Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Namjae Jeon <linkinjeon@kernel.org> Cc: Steve French <sfrench@samba.org> Cc: Sergey Senozhatsky <senozhatsky@chromium.org> Cc: Tom Talpey <tom@talpey.com> Cc: linux-cifs@vger.kernel.org Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent b4068f1 commit 8d99c11

File tree

1 file changed

+18
-10
lines changed

1 file changed

+18
-10
lines changed

fs/smb/server/vfs.c

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@ static void ksmbd_vfs_inherit_owner(struct ksmbd_work *work,
4949

5050
/**
5151
* ksmbd_vfs_lock_parent() - lock parent dentry if it is stable
52+
* @parent: parent dentry
53+
* @child: child dentry
54+
*
55+
* Returns: %0 on success, %-ENOENT if the parent dentry is not stable
5256
*/
5357
int ksmbd_vfs_lock_parent(struct dentry *parent, struct dentry *child)
5458
{
@@ -360,7 +364,7 @@ static int check_lock_range(struct file *filp, loff_t start, loff_t end,
360364
/**
361365
* ksmbd_vfs_read() - vfs helper for smb file read
362366
* @work: smb work
363-
* @fid: file id of open file
367+
* @fp: ksmbd file pointer
364368
* @count: read byte count
365369
* @pos: file pos
366370
* @rbuf: read data buffer
@@ -474,7 +478,7 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *fp, char *buf, loff_t *pos,
474478
/**
475479
* ksmbd_vfs_write() - vfs helper for smb file write
476480
* @work: work
477-
* @fid: file id of open file
481+
* @fp: ksmbd file pointer
478482
* @buf: buf containing data for writing
479483
* @count: read byte count
480484
* @pos: file pos
@@ -545,10 +549,8 @@ int ksmbd_vfs_write(struct ksmbd_work *work, struct ksmbd_file *fp,
545549

546550
/**
547551
* ksmbd_vfs_getattr() - vfs helper for smb getattr
548-
* @work: work
549-
* @fid: file id of open file
550-
* @attrs: inode attributes
551-
*
552+
* @path: path of dentry
553+
* @stat: pointer to returned kernel stat structure
552554
* Return: 0 on success, otherwise error
553555
*/
554556
int ksmbd_vfs_getattr(const struct path *path, struct kstat *stat)
@@ -565,6 +567,7 @@ int ksmbd_vfs_getattr(const struct path *path, struct kstat *stat)
565567
* ksmbd_vfs_fsync() - vfs helper for smb fsync
566568
* @work: work
567569
* @fid: file id of open file
570+
* @p_id: persistent file id
568571
*
569572
* Return: 0 on success, otherwise error
570573
*/
@@ -587,7 +590,8 @@ int ksmbd_vfs_fsync(struct ksmbd_work *work, u64 fid, u64 p_id)
587590

588591
/**
589592
* ksmbd_vfs_remove_file() - vfs helper for smb rmdir or unlink
590-
* @name: directory or file name that is relative to share
593+
* @work: work
594+
* @path: path of dentry
591595
*
592596
* Return: 0 on success, otherwise error
593597
*/
@@ -623,6 +627,7 @@ int ksmbd_vfs_remove_file(struct ksmbd_work *work, const struct path *path)
623627

624628
/**
625629
* ksmbd_vfs_link() - vfs helper for creating smb hardlink
630+
* @work: work
626631
* @oldname: source file name
627632
* @newname: hardlink name that is relative to share
628633
*
@@ -795,7 +800,7 @@ int ksmbd_vfs_rename(struct ksmbd_work *work, const struct path *old_path,
795800
/**
796801
* ksmbd_vfs_truncate() - vfs helper for smb file truncate
797802
* @work: work
798-
* @fid: file id of old file
803+
* @fp: ksmbd file pointer
799804
* @size: truncate to given size
800805
*
801806
* Return: 0 on success, otherwise error
@@ -838,7 +843,6 @@ int ksmbd_vfs_truncate(struct ksmbd_work *work,
838843
* ksmbd_vfs_listxattr() - vfs helper for smb list extended attributes
839844
* @dentry: dentry of file for listing xattrs
840845
* @list: destination buffer
841-
* @size: destination buffer length
842846
*
843847
* Return: xattr list length on success, otherwise error
844848
*/
@@ -947,7 +951,7 @@ int ksmbd_vfs_setxattr(struct mnt_idmap *idmap,
947951
/**
948952
* ksmbd_vfs_set_fadvise() - convert smb IO caching options to linux options
949953
* @filp: file pointer for IO
950-
* @options: smb IO options
954+
* @option: smb IO options
951955
*/
952956
void ksmbd_vfs_set_fadvise(struct file *filp, __le32 option)
953957
{
@@ -1159,6 +1163,7 @@ static bool __caseless_lookup(struct dir_context *ctx, const char *name,
11591163
* @dir: path info
11601164
* @name: filename to lookup
11611165
* @namelen: filename length
1166+
* @um: &struct unicode_map to use
11621167
*
11631168
* Return: 0 on success, otherwise error
11641169
*/
@@ -1189,6 +1194,7 @@ static int ksmbd_vfs_lookup_in_dir(const struct path *dir, char *name,
11891194

11901195
/**
11911196
* ksmbd_vfs_kern_path_locked() - lookup a file and get path info
1197+
* @work: work
11921198
* @name: file path that is relative to share
11931199
* @flags: lookup flags
11941200
* @parent_path: if lookup succeed, return parent_path info
@@ -1636,6 +1642,8 @@ int ksmbd_vfs_get_dos_attrib_xattr(struct mnt_idmap *idmap,
16361642
* ksmbd_vfs_init_kstat() - convert unix stat information to smb stat format
16371643
* @p: destination buffer
16381644
* @ksmbd_kstat: ksmbd kstat wrapper
1645+
*
1646+
* Returns: pointer to the converted &struct file_directory_info
16391647
*/
16401648
void *ksmbd_vfs_init_kstat(char **p, struct ksmbd_kstat *ksmbd_kstat)
16411649
{

0 commit comments

Comments
 (0)