Skip to content

Commit 8d7ed10

Browse files
committed
Merge tag 'char-misc-5.16-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
Pull char/misc driver fixes from Greg KH: "Here are a bunch of small char/misc and other driver subsystem fixes. Included in here are: - iio driver fixes for reported problems - phy driver fixes for a number of reported problems - mhi resume bugfix for broken hardware - nvmem driver fix - rtsx driver fix for irq issues - fastrpc packet parsing fix All of these have been in linux-next for a while with no reported issues" * tag 'char-misc-5.16-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (33 commits) bus: mhi: core: Add support for forced PM resume iio: trigger: stm32-timer: fix MODULE_ALIAS misc: rtsx: Avoid mangling IRQ during runtime PM nvmem: eeprom: at25: fix FRAM byte_len misc: fastrpc: fix improper packet size calculation MAINTAINERS: add maintainer for Qualcomm FastRPC driver bus: mhi: pci_generic: Fix device recovery failed issue iio: adc: stm32: fix null pointer on defer_probe error phy: HiSilicon: Fix copy and paste bug in error handling dt-bindings: phy: zynqmp-psgtr: fix USB phy name phy: ti: omap-usb2: Fix the kernel-doc style phy: qualcomm: ipq806x-usb: Fix kernel-doc style iio: at91-sama5d2: Fix incorrect sign extension iio: adc: axp20x_adc: fix charging current reporting on AXP22x iio: gyro: adxrs290: fix data signedness phy: ti: tusb1210: Fix the kernel-doc warn phy: qualcomm: usb-hsic: Fix the kernel-doc warn phy: qualcomm: qmp: Add missing struct documentation phy: mvebu-cp110-utmi: Fix kernel-doc warns iio: ad7768-1: Call iio_trigger_notify_done() on error ...
2 parents c7fc512 + cab2d3f commit 8d7ed10

34 files changed

+136
-102
lines changed

Documentation/devicetree/bindings/phy/xlnx,zynqmp-psgtr.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ properties:
2929
- PHY_TYPE_PCIE
3030
- PHY_TYPE_SATA
3131
- PHY_TYPE_SGMII
32-
- PHY_TYPE_USB
32+
- PHY_TYPE_USB3
3333
- description: The PHY instance
3434
minimum: 0
3535
maximum: 1 # for DP, SATA or USB

MAINTAINERS

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15770,6 +15770,15 @@ S: Maintained
1577015770
F: Documentation/devicetree/bindings/net/qcom,ethqos.txt
1577115771
F: drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
1577215772

15773+
QUALCOMM FASTRPC DRIVER
15774+
M: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
15775+
M: Amol Maheshwari <amahesh@qti.qualcomm.com>
15776+
L: linux-arm-msm@vger.kernel.org
15777+
S: Maintained
15778+
F: Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
15779+
F: drivers/misc/fastrpc.c
15780+
F: include/uapi/misc/fastrpc.h
15781+
1577315782
QUALCOMM GENERIC INTERFACE I2C DRIVER
1577415783
M: Akash Asthana <akashast@codeaurora.org>
1577515784
M: Mukesh Savaliya <msavaliy@codeaurora.org>

drivers/bus/mhi/core/pm.c

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -881,7 +881,7 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl)
881881
}
882882
EXPORT_SYMBOL_GPL(mhi_pm_suspend);
883883

884-
int mhi_pm_resume(struct mhi_controller *mhi_cntrl)
884+
static int __mhi_pm_resume(struct mhi_controller *mhi_cntrl, bool force)
885885
{
886886
struct mhi_chan *itr, *tmp;
887887
struct device *dev = &mhi_cntrl->mhi_dev->dev;
@@ -898,8 +898,12 @@ int mhi_pm_resume(struct mhi_controller *mhi_cntrl)
898898
if (MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state))
899899
return -EIO;
900900

901-
if (mhi_get_mhi_state(mhi_cntrl) != MHI_STATE_M3)
902-
return -EINVAL;
901+
if (mhi_get_mhi_state(mhi_cntrl) != MHI_STATE_M3) {
902+
dev_warn(dev, "Resuming from non M3 state (%s)\n",
903+
TO_MHI_STATE_STR(mhi_get_mhi_state(mhi_cntrl)));
904+
if (!force)
905+
return -EINVAL;
906+
}
903907

904908
/* Notify clients about exiting LPM */
905909
list_for_each_entry_safe(itr, tmp, &mhi_cntrl->lpm_chans, node) {
@@ -940,8 +944,19 @@ int mhi_pm_resume(struct mhi_controller *mhi_cntrl)
940944

941945
return 0;
942946
}
947+
948+
int mhi_pm_resume(struct mhi_controller *mhi_cntrl)
949+
{
950+
return __mhi_pm_resume(mhi_cntrl, false);
951+
}
943952
EXPORT_SYMBOL_GPL(mhi_pm_resume);
944953

954+
int mhi_pm_resume_force(struct mhi_controller *mhi_cntrl)
955+
{
956+
return __mhi_pm_resume(mhi_cntrl, true);
957+
}
958+
EXPORT_SYMBOL_GPL(mhi_pm_resume_force);
959+
945960
int __mhi_device_get_sync(struct mhi_controller *mhi_cntrl)
946961
{
947962
int ret;

drivers/bus/mhi/pci_generic.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
#define MHI_PCI_DEFAULT_BAR_NUM 0
2222

23-
#define MHI_POST_RESET_DELAY_MS 500
23+
#define MHI_POST_RESET_DELAY_MS 2000
2424

2525
#define HEALTH_CHECK_PERIOD (HZ * 2)
2626

drivers/iio/accel/kxcjk-1013.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1595,8 +1595,7 @@ static int kxcjk1013_probe(struct i2c_client *client,
15951595
return 0;
15961596

15971597
err_buffer_cleanup:
1598-
if (data->dready_trig)
1599-
iio_triggered_buffer_cleanup(indio_dev);
1598+
iio_triggered_buffer_cleanup(indio_dev);
16001599
err_trigger_unregister:
16011600
if (data->dready_trig)
16021601
iio_trigger_unregister(data->dready_trig);
@@ -1618,8 +1617,8 @@ static int kxcjk1013_remove(struct i2c_client *client)
16181617
pm_runtime_disable(&client->dev);
16191618
pm_runtime_set_suspended(&client->dev);
16201619

1620+
iio_triggered_buffer_cleanup(indio_dev);
16211621
if (data->dready_trig) {
1622-
iio_triggered_buffer_cleanup(indio_dev);
16231622
iio_trigger_unregister(data->dready_trig);
16241623
iio_trigger_unregister(data->motion_trig);
16251624
}

drivers/iio/accel/kxsd9.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,14 +224,14 @@ static irqreturn_t kxsd9_trigger_handler(int irq, void *p)
224224
hw_values.chan,
225225
sizeof(hw_values.chan));
226226
if (ret) {
227-
dev_err(st->dev,
228-
"error reading data\n");
229-
return ret;
227+
dev_err(st->dev, "error reading data: %d\n", ret);
228+
goto out;
230229
}
231230

232231
iio_push_to_buffers_with_timestamp(indio_dev,
233232
&hw_values,
234233
iio_get_time_ns(indio_dev));
234+
out:
235235
iio_trigger_notify_done(indio_dev->trig);
236236

237237
return IRQ_HANDLED;

drivers/iio/accel/mma8452.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1470,7 +1470,7 @@ static int mma8452_trigger_setup(struct iio_dev *indio_dev)
14701470
if (ret)
14711471
return ret;
14721472

1473-
indio_dev->trig = trig;
1473+
indio_dev->trig = iio_trigger_get(trig);
14741474

14751475
return 0;
14761476
}

drivers/iio/adc/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ config IMX7D_ADC
532532

533533
config IMX8QXP_ADC
534534
tristate "NXP IMX8QXP ADC driver"
535-
depends on ARCH_MXC_ARM64 || COMPILE_TEST
535+
depends on ARCH_MXC || COMPILE_TEST
536536
depends on HAS_IOMEM
537537
help
538538
Say yes here to build support for IMX8QXP ADC.

drivers/iio/adc/ad7768-1.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -480,8 +480,8 @@ static irqreturn_t ad7768_trigger_handler(int irq, void *p)
480480
iio_push_to_buffers_with_timestamp(indio_dev, &st->data.scan,
481481
iio_get_time_ns(indio_dev));
482482

483-
iio_trigger_notify_done(indio_dev->trig);
484483
err_unlock:
484+
iio_trigger_notify_done(indio_dev->trig);
485485
mutex_unlock(&st->lock);
486486

487487
return IRQ_HANDLED;

drivers/iio/adc/at91-sama5d2_adc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1586,7 +1586,8 @@ static int at91_adc_read_info_raw(struct iio_dev *indio_dev,
15861586
*val = st->conversion_value;
15871587
ret = at91_adc_adjust_val_osr(st, val);
15881588
if (chan->scan_type.sign == 's')
1589-
*val = sign_extend32(*val, 11);
1589+
*val = sign_extend32(*val,
1590+
chan->scan_type.realbits - 1);
15901591
st->conversion_done = false;
15911592
}
15921593

0 commit comments

Comments
 (0)