Skip to content

Commit 8c47ac2

Browse files
Uwe Kleine-Königkwilczynski
authored andcommitted
PCI: mt7621: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Link: https://lore.kernel.org/linux-pci/20230321193208.366561-12-u.kleine-koenig@pengutronix.de Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
1 parent 22626c4 commit 8c47ac2

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/pci/controller/pcie-mt7621.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -524,15 +524,13 @@ static int mt7621_pcie_probe(struct platform_device *pdev)
524524
return err;
525525
}
526526

527-
static int mt7621_pcie_remove(struct platform_device *pdev)
527+
static void mt7621_pcie_remove(struct platform_device *pdev)
528528
{
529529
struct mt7621_pcie *pcie = platform_get_drvdata(pdev);
530530
struct mt7621_pcie_port *port;
531531

532532
list_for_each_entry(port, &pcie->ports, list)
533533
reset_control_put(port->pcie_rst);
534-
535-
return 0;
536534
}
537535

538536
static const struct of_device_id mt7621_pcie_ids[] = {
@@ -543,7 +541,7 @@ MODULE_DEVICE_TABLE(of, mt7621_pcie_ids);
543541

544542
static struct platform_driver mt7621_pcie_driver = {
545543
.probe = mt7621_pcie_probe,
546-
.remove = mt7621_pcie_remove,
544+
.remove_new = mt7621_pcie_remove,
547545
.driver = {
548546
.name = "mt7621-pci",
549547
.of_match_table = mt7621_pcie_ids,

0 commit comments

Comments
 (0)