Skip to content

Commit 8b936fc

Browse files
Shrikanth HegdeIngo Molnar
authored andcommitted
sched/fair: Use existing helper functions to access ->avg_rt and ->avg_dl
There are helper functions called cpu_util_dl() and cpu_util_rt() which give the average utilization of DL and RT respectively. But there are a few places in code where access to these variables is open-coded. Instead use the helper function so that code becomes simpler and easier to maintain later on. No functional changes intended. Signed-off-by: Shrikanth Hegde <sshegde@linux.vnet.ibm.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org> Link: https://lore.kernel.org/r/20240101154624.100981-2-sshegde@linux.vnet.ibm.com
1 parent 8cec3dd commit 8b936fc

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

kernel/sched/fair.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9237,10 +9237,10 @@ static inline bool cfs_rq_has_blocked(struct cfs_rq *cfs_rq)
92379237

92389238
static inline bool others_have_blocked(struct rq *rq)
92399239
{
9240-
if (READ_ONCE(rq->avg_rt.util_avg))
9240+
if (cpu_util_rt(rq))
92419241
return true;
92429242

9243-
if (READ_ONCE(rq->avg_dl.util_avg))
9243+
if (cpu_util_dl(rq))
92449244
return true;
92459245

92469246
if (thermal_load_avg(rq))
@@ -9506,8 +9506,8 @@ static unsigned long scale_rt_capacity(int cpu)
95069506
* avg_thermal.load_avg tracks thermal pressure and the weighted
95079507
* average uses the actual delta max capacity(load).
95089508
*/
9509-
used = READ_ONCE(rq->avg_rt.util_avg);
9510-
used += READ_ONCE(rq->avg_dl.util_avg);
9509+
used = cpu_util_rt(rq);
9510+
used += cpu_util_dl(rq);
95119511
used += thermal_load_avg(rq);
95129512

95139513
if (unlikely(used >= max))

0 commit comments

Comments
 (0)