Skip to content

Commit 8b79d4e

Browse files
palmer-dabbeltgregkh
authored andcommitted
tty: hvc: Don't enable the RISC-V SBI console by default
The new SBI console has the same problem as the old one: there's only one shared backing hardware and no synchronization, so the two drivers end up stepping on each other. This was the same issue the old SBI-0.1 console drivers had, but that was disabled by default when SBI-0.1 was. So just mark the new driver as nonportable. Reported-by: Emil Renner Berthing <kernel@esmil.dk> Fixes: 88ead68 ("tty: Add SBI debug console support to HVC SBI driver") Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com> Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com> Reviewed-by: Anup Patel <anup@brainfault.org> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Link: https://lore.kernel.org/r/20240214153429.16484-2-palmer@rivosinc.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent b401b62 commit 8b79d4e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

drivers/tty/hvc/Kconfig

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,15 @@ config HVC_DCC_SERIALIZE_SMP
108108

109109
config HVC_RISCV_SBI
110110
bool "RISC-V SBI console support"
111-
depends on RISCV_SBI
111+
depends on RISCV_SBI && NONPORTABLE
112112
select HVC_DRIVER
113113
help
114114
This enables support for console output via RISC-V SBI calls, which
115-
is normally used only during boot to output printk.
115+
is normally used only during boot to output printk. This driver
116+
conflicts with real console drivers and should not be enabled on
117+
systems that directly access the console.
116118

117-
If you don't know what do to here, say Y.
119+
If you don't know what do to here, say N.
118120

119121
config HVCS
120122
tristate "IBM Hypervisor Virtual Console Server support"

0 commit comments

Comments
 (0)