Skip to content

Commit 8ad00c1

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: stm32mp1: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-17-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent dd90484 commit 8ad00c1

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

drivers/clk/clk-stm32mp1.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2434,15 +2434,13 @@ static int stm32mp1_rcc_clocks_probe(struct platform_device *pdev)
24342434
return ret;
24352435
}
24362436

2437-
static int stm32mp1_rcc_clocks_remove(struct platform_device *pdev)
2437+
static void stm32mp1_rcc_clocks_remove(struct platform_device *pdev)
24382438
{
24392439
struct device *dev = &pdev->dev;
24402440
struct device_node *child, *np = dev_of_node(dev);
24412441

24422442
for_each_available_child_of_node(np, child)
24432443
of_clk_del_provider(child);
2444-
2445-
return 0;
24462444
}
24472445

24482446
static struct platform_driver stm32mp1_rcc_clocks_driver = {
@@ -2451,7 +2449,7 @@ static struct platform_driver stm32mp1_rcc_clocks_driver = {
24512449
.of_match_table = stm32mp1_match_data,
24522450
},
24532451
.probe = stm32mp1_rcc_clocks_probe,
2454-
.remove = stm32mp1_rcc_clocks_remove,
2452+
.remove_new = stm32mp1_rcc_clocks_remove,
24552453
};
24562454

24572455
static int __init stm32mp1_clocks_init(void)

0 commit comments

Comments
 (0)