Skip to content

Commit 8a904a3

Browse files
sulixshuahkh
authored andcommitted
rtc: test: Fix invalid format specifier.
'days' is a s64 (from div_s64), and so should use a %lld specifier. This was found by extending KUnit's assertion macros to use gcc's __printf attribute. Fixes: 1d1bb12 ("rtc: Improve performance of rtc_time64_to_tm(). Add tests.") Signed-off-by: David Gow <davidgow@google.com> Tested-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Justin Stitt <justinstitt@google.com> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
1 parent 133e267 commit 8a904a3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/rtc/lib_test.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ static void rtc_time64_to_tm_test_date_range(struct kunit *test)
5454

5555
days = div_s64(secs, 86400);
5656

57-
#define FAIL_MSG "%d/%02d/%02d (%2d) : %ld", \
57+
#define FAIL_MSG "%d/%02d/%02d (%2d) : %lld", \
5858
year, month, mday, yday, days
5959

6060
KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, FAIL_MSG);

0 commit comments

Comments
 (0)