Skip to content

Commit 8a317e0

Browse files
Lotte-Baibroonie
authored andcommitted
regulator: vctrl: Use min() instead of doing it manually
Fix following coccicheck warning: drivers/regulator/vctrl-regulator.c:188:15-17: WARNING opportunity for max() Signed-off-by: Haowen Bai <baihaowen@meizu.com> Link: https://lore.kernel.org/r/1647315190-16139-1-git-send-email-baihaowen@meizu.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 760423d commit 8a317e0

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

drivers/regulator/vctrl-regulator.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,10 +185,7 @@ static int vctrl_set_voltage_sel(struct regulator_dev *rdev,
185185
unsigned int next_sel;
186186
int delay;
187187

188-
if (selector >= vctrl->vtable[vctrl->sel].ovp_min_sel)
189-
next_sel = selector;
190-
else
191-
next_sel = vctrl->vtable[vctrl->sel].ovp_min_sel;
188+
next_sel = max_t(unsigned int, selector, vctrl->vtable[vctrl->sel].ovp_min_sel);
192189

193190
ret = regulator_set_voltage_rdev(rdev->supply->rdev,
194191
vctrl->vtable[next_sel].ctrl,

0 commit comments

Comments
 (0)