Skip to content

Commit 8a2b20a

Browse files
YuKuai-huaweiaxboe
authored andcommitted
blk-wbt: fix that wbt can't be disabled by default
commit b11d31a ("blk-wbt: remove unnecessary check in wbt_enable_default()") removes the checking of CONFIG_BLK_WBT_MQ by mistake, which is used to control enable or disable wbt by default. Fix the problem by adding back the checking. This patch also do a litter cleanup to make related code more readable. Fixes: b11d31a ("blk-wbt: remove unnecessary check in wbt_enable_default()") Reported-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Link: https://lore.kernel.org/lkml/CAKXUXMzfKq_J9nKHGyr5P5rvUETY4B-fxoQD4sO+NYjFOfVtZA@mail.gmail.com/t/ Signed-off-by: Yu Kuai <yukuai3@huawei.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Link: https://lore.kernel.org/r/20230522121854.2928880-1-yukuai1@huaweicloud.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent e3afec9 commit 8a2b20a

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

block/blk-wbt.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -730,14 +730,16 @@ void wbt_enable_default(struct gendisk *disk)
730730
{
731731
struct request_queue *q = disk->queue;
732732
struct rq_qos *rqos;
733-
bool disable_flag = q->elevator &&
734-
test_bit(ELEVATOR_FLAG_DISABLE_WBT, &q->elevator->flags);
733+
bool enable = IS_ENABLED(CONFIG_BLK_WBT_MQ);
734+
735+
if (q->elevator &&
736+
test_bit(ELEVATOR_FLAG_DISABLE_WBT, &q->elevator->flags))
737+
enable = false;
735738

736739
/* Throttling already enabled? */
737740
rqos = wbt_rq_qos(q);
738741
if (rqos) {
739-
if (!disable_flag &&
740-
RQWB(rqos)->enable_state == WBT_STATE_OFF_DEFAULT)
742+
if (enable && RQWB(rqos)->enable_state == WBT_STATE_OFF_DEFAULT)
741743
RQWB(rqos)->enable_state = WBT_STATE_ON_DEFAULT;
742744
return;
743745
}
@@ -746,7 +748,7 @@ void wbt_enable_default(struct gendisk *disk)
746748
if (!blk_queue_registered(q))
747749
return;
748750

749-
if (queue_is_mq(q) && !disable_flag)
751+
if (queue_is_mq(q) && enable)
750752
wbt_init(disk);
751753
}
752754
EXPORT_SYMBOL_GPL(wbt_enable_default);

0 commit comments

Comments
 (0)