Skip to content

Commit 89fe460

Browse files
committed
drm/v3d: Fix support for register debugging on the RPi 4
RPi 4 uses V3D 4.2, which is currently not supported by the register definition stated at `v3d_core_reg_defs`. We should be able to support V3D 4.2, therefore, change the maximum version of the register definition to 42, not 41. Fixes: 0ad5bc1 ("drm/v3d: fix up register addresses for V3D 7.x") Signed-off-by: Maíra Canal <mcanal@igalia.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240109113126.929446-1-mcanal@igalia.com
1 parent 196da3f commit 89fe460

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

drivers/gpu/drm/v3d/v3d_debugfs.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,9 @@ static const struct v3d_reg_def v3d_core_reg_defs[] = {
6262
REGDEF(33, 71, V3D_PTB_BPCA),
6363
REGDEF(33, 71, V3D_PTB_BPCS),
6464

65-
REGDEF(33, 41, V3D_GMP_STATUS(33)),
66-
REGDEF(33, 41, V3D_GMP_CFG(33)),
67-
REGDEF(33, 41, V3D_GMP_VIO_ADDR(33)),
65+
REGDEF(33, 42, V3D_GMP_STATUS(33)),
66+
REGDEF(33, 42, V3D_GMP_CFG(33)),
67+
REGDEF(33, 42, V3D_GMP_VIO_ADDR(33)),
6868

6969
REGDEF(33, 71, V3D_ERR_FDBGO),
7070
REGDEF(33, 71, V3D_ERR_FDBGB),
@@ -74,13 +74,13 @@ static const struct v3d_reg_def v3d_core_reg_defs[] = {
7474

7575
static const struct v3d_reg_def v3d_csd_reg_defs[] = {
7676
REGDEF(41, 71, V3D_CSD_STATUS),
77-
REGDEF(41, 41, V3D_CSD_CURRENT_CFG0(41)),
78-
REGDEF(41, 41, V3D_CSD_CURRENT_CFG1(41)),
79-
REGDEF(41, 41, V3D_CSD_CURRENT_CFG2(41)),
80-
REGDEF(41, 41, V3D_CSD_CURRENT_CFG3(41)),
81-
REGDEF(41, 41, V3D_CSD_CURRENT_CFG4(41)),
82-
REGDEF(41, 41, V3D_CSD_CURRENT_CFG5(41)),
83-
REGDEF(41, 41, V3D_CSD_CURRENT_CFG6(41)),
77+
REGDEF(41, 42, V3D_CSD_CURRENT_CFG0(41)),
78+
REGDEF(41, 42, V3D_CSD_CURRENT_CFG1(41)),
79+
REGDEF(41, 42, V3D_CSD_CURRENT_CFG2(41)),
80+
REGDEF(41, 42, V3D_CSD_CURRENT_CFG3(41)),
81+
REGDEF(41, 42, V3D_CSD_CURRENT_CFG4(41)),
82+
REGDEF(41, 42, V3D_CSD_CURRENT_CFG5(41)),
83+
REGDEF(41, 42, V3D_CSD_CURRENT_CFG6(41)),
8484
REGDEF(71, 71, V3D_CSD_CURRENT_CFG0(71)),
8585
REGDEF(71, 71, V3D_CSD_CURRENT_CFG1(71)),
8686
REGDEF(71, 71, V3D_CSD_CURRENT_CFG2(71)),

0 commit comments

Comments
 (0)