Skip to content

Commit 89c290e

Browse files
khfengrafaeljw
authored andcommitted
ACPI: video: Put ACPI video and its child devices into D0 on boot
Screen brightness can only be changed once on HP ZBook Fury 16 G10. The vendor reports that the issue is related to the fact that Linux doesn't invoke _PS0 at boot for all ACPI devices, as expected by the platform firmware: Scope (\_SB.PC00.GFX0) { Scope (DD1F) { Method (_PS0, 0, Serialized) // _PS0: Power State 0 { If (CondRefOf (\_SB.PC00.LPCB.EC0.SSBC)) { \_SB.PC00.LPCB.EC0.SSBC () } } ... } ... } The \_SB.PC00.GFX0.DD1F is the panel device, and its _PS0 needs to be executed at the initialization time to make the brightness control work properly. _PS0 is not evaluated for this device, because _PSC is missing, which violates the ACPI specification (ACPI 6.5, section 7.3.6). Commit b378549 ("ACPI / PM: Do not power manage devices in unknown initial states") tried to work around missing _PSC on platforms with defective firmware, but got reverted due to a regression. So the safest approach is to use acpi_device_fix_up_power_extended() to put ACPI video and its child devices to D0 to address the issue at hand. Link: https://bugzilla.kernel.org/show_bug.cgi?id=217683 Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com> [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 96b709b commit 89c290e

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/acpi/acpi_video.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2027,6 +2027,12 @@ static int acpi_video_bus_add(struct acpi_device *device)
20272027
if (error)
20282028
goto err_put_video;
20292029

2030+
/*
2031+
* HP ZBook Fury 16 G10 requires ACPI video's child devices have _PS0
2032+
* evaluated to have functional panel brightness control.
2033+
*/
2034+
acpi_device_fix_up_power_extended(device);
2035+
20302036
pr_info("%s [%s] (multi-head: %s rom: %s post: %s)\n",
20312037
ACPI_VIDEO_DEVICE_NAME, acpi_device_bid(device),
20322038
video->flags.multihead ? "yes" : "no",

0 commit comments

Comments
 (0)