Skip to content

Commit 8874ad7

Browse files
chaseyuJaegeuk Kim
authored andcommitted
f2fs: fix to update i_ctime in __f2fs_setxattr()
generic/728 - output mismatch (see /media/fstests/results//generic/728.out.bad) --- tests/generic/728.out 2023-07-19 07:10:48.362711407 +0000 +++ /media/fstests/results//generic/728.out.bad 2023-07-19 08:39:57.000000000 +0000 QA output created by 728 +Expected ctime to change after setxattr. +Expected ctime to change after removexattr. Silence is golden ... (Run 'diff -u /media/fstests/tests/generic/728.out /media/fstests/results//generic/728.out.bad' to see the entire diff) generic/729 1s It needs to update i_ctime after {set,remove}xattr, fix it. Signed-off-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
1 parent 958ccbb commit 8874ad7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

fs/f2fs/xattr.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -757,17 +757,17 @@ static int __f2fs_setxattr(struct inode *inode, int index,
757757
if (index == F2FS_XATTR_INDEX_ENCRYPTION &&
758758
!strcmp(name, F2FS_XATTR_NAME_ENCRYPTION_CONTEXT))
759759
f2fs_set_encrypted_inode(inode);
760-
f2fs_mark_inode_dirty_sync(inode, true);
761760
if (!error && S_ISDIR(inode->i_mode))
762761
set_sbi_flag(F2FS_I_SB(inode), SBI_NEED_CP);
763762

764763
same:
765764
if (is_inode_flag_set(inode, FI_ACL_MODE)) {
766765
inode->i_mode = F2FS_I(inode)->i_acl_mode;
767-
inode->i_ctime = current_time(inode);
768766
clear_inode_flag(inode, FI_ACL_MODE);
769767
}
770768

769+
inode->i_ctime = current_time(inode);
770+
f2fs_mark_inode_dirty_sync(inode, true);
771771
exit:
772772
kfree(base_addr);
773773
return error;

0 commit comments

Comments
 (0)