Skip to content

Commit 87cea48

Browse files
author
Wolfram Sang
committed
Merge tag 'i2c-host-fixes-6.11-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux into i2c/for-current
Two fixes in this update: Tegra I2C Controller: Addresses a potential double-locking issue during probe. ACPI devices are not IRQ-safe when invoking runtime suspend and resume functions, so the irq_safe flag should not be set. Qualcomm GENI I2C Controller: Fixes an oversight in the exit path of the runtime_resume() function, which was missed in the previous release.
2 parents 71833e7 + 14d069d commit 87cea48

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

drivers/i2c/busses/i2c-qcom-geni.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -986,8 +986,10 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev)
986986
return ret;
987987

988988
ret = clk_prepare_enable(gi2c->core_clk);
989-
if (ret)
989+
if (ret) {
990+
geni_icc_disable(&gi2c->se);
990991
return ret;
992+
}
991993

992994
ret = geni_se_resources_on(&gi2c->se);
993995
if (ret) {

drivers/i2c/busses/i2c-tegra.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1802,9 +1802,9 @@ static int tegra_i2c_probe(struct platform_device *pdev)
18021802
* domain.
18031803
*
18041804
* VI I2C device shouldn't be marked as IRQ-safe because VI I2C won't
1805-
* be used for atomic transfers.
1805+
* be used for atomic transfers. ACPI device is not IRQ safe also.
18061806
*/
1807-
if (!IS_VI(i2c_dev))
1807+
if (!IS_VI(i2c_dev) && !has_acpi_companion(i2c_dev->dev))
18081808
pm_runtime_irq_safe(i2c_dev->dev);
18091809

18101810
pm_runtime_enable(i2c_dev->dev);

0 commit comments

Comments
 (0)