Skip to content

Commit 8623ccb

Browse files
Yang Yingliangjonmason
authored andcommitted
NTB: ntb_transport: fix possible memory leak while device_register() fails
If device_register() returns error, the name allocated by dev_set_name() need be freed. As comment of device_register() says, it should use put_device() to give up the reference in the error path. So fix this by calling put_device(), then the name can be freed in kobject_cleanup(), and client_dev is freed in ntb_transport_client_release(). Fixes: fce8a7b ("PCI-Express Non-Transparent Bridge Support") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Jon Mason <jdmason@kudzu.us>
1 parent 4c3c796 commit 8623ccb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/ntb/ntb_transport.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ int ntb_transport_register_client_dev(char *device_name)
410410

411411
rc = device_register(dev);
412412
if (rc) {
413-
kfree(client_dev);
413+
put_device(dev);
414414
goto err;
415415
}
416416

0 commit comments

Comments
 (0)