Skip to content

Commit 85a063b

Browse files
arndblumag
authored andcommitted
drm/i2c: tda998x: select CONFIG_DRM_KMS_HELPER
This fails to build without the KMS helper functions: x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o: in function `tda998x_detect_work': tda998x_drv.c:(.text+0x4e6): undefined reference to `drm_kms_helper_hotplug_event' x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o: in function `tda998x_bind': tda998x_drv.c:(.text.unlikely+0x33): undefined reference to `drm_simple_encoder_init' x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x584): undefined reference to `drm_atomic_helper_connector_reset' x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x590): undefined reference to `drm_helper_probe_single_connector_modes' x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x5a4): undefined reference to `drm_atomic_helper_connector_duplicate_state' x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o:(.rodata+0x5a8): undefined reference to `drm_atomic_helper_connector_destroy_state' Select the missing symbol and fix up the broken whitespace. Fixes: 325ba85 ("drm/i2c: move TDA998x driver under drivers/gpu/drm/bridge") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/r/20250324210824.3094660-1-arnd@kernel.org Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
1 parent ee20c69 commit 85a063b

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

drivers/gpu/drm/bridge/Kconfig

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,13 @@ config DRM_FSL_LDB
9191
Support for i.MX8MP DPI-to-LVDS on-SoC encoder.
9292

9393
config DRM_I2C_NXP_TDA998X
94-
tristate "NXP Semiconductors TDA998X HDMI encoder"
95-
default m if DRM_TILCDC
96-
select CEC_CORE if CEC_NOTIFIER
97-
select SND_SOC_HDMI_CODEC if SND_SOC
98-
help
99-
Support for NXP Semiconductors TDA998X HDMI encoders.
94+
tristate "NXP Semiconductors TDA998X HDMI encoder"
95+
default m if DRM_TILCDC
96+
select CEC_CORE if CEC_NOTIFIER
97+
select DRM_KMS_HELPER
98+
select SND_SOC_HDMI_CODEC if SND_SOC
99+
help
100+
Support for NXP Semiconductors TDA998X HDMI encoders.
100101

101102
config DRM_ITE_IT6263
102103
tristate "ITE IT6263 LVDS/HDMI bridge"

0 commit comments

Comments
 (0)