Skip to content

Commit 838de1d

Browse files
Ravi BangoriaPeter Zijlstra
authored andcommitted
perf/amd/ibs: Advertise zen4_ibs_extensions as pmu capability attribute
PMU driver can advertise certain feature via capability attribute('caps' sysfs directory) which can be consumed by userspace tools like perf. Add zen4_ibs_extensions capability attribute for IBS pmus. This attribute will be enabled when CPUID_Fn8000001B_EAX[11] is set. With patch on Zen4: $ ls /sys/bus/event_source/devices/ibs_op/caps zen4_ibs_extensions Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lore.kernel.org/r/20220509044914.1473-5-ravi.bangoria@amd.com
1 parent ba5d35b commit 838de1d

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

arch/x86/events/amd/ibs.c

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -537,15 +537,22 @@ static struct attribute_group empty_format_group = {
537537
.attrs = attrs_empty,
538538
};
539539

540+
static struct attribute_group empty_caps_group = {
541+
.name = "caps",
542+
.attrs = attrs_empty,
543+
};
544+
540545
static const struct attribute_group *empty_attr_groups[] = {
541546
&empty_format_group,
547+
&empty_caps_group,
542548
NULL,
543549
};
544550

545551
PMU_FORMAT_ATTR(rand_en, "config:57");
546552
PMU_FORMAT_ATTR(cnt_ctl, "config:19");
547553
PMU_EVENT_ATTR_STRING(l3missonly, fetch_l3missonly, "config:59");
548554
PMU_EVENT_ATTR_STRING(l3missonly, op_l3missonly, "config:16");
555+
PMU_EVENT_ATTR_STRING(zen4_ibs_extensions, zen4_ibs_extensions, "1");
549556

550557
static umode_t
551558
zen4_ibs_extensions_is_visible(struct kobject *kobj, struct attribute *attr, int i)
@@ -563,6 +570,11 @@ static struct attribute *fetch_l3missonly_attrs[] = {
563570
NULL,
564571
};
565572

573+
static struct attribute *zen4_ibs_extensions_attrs[] = {
574+
&zen4_ibs_extensions.attr.attr,
575+
NULL,
576+
};
577+
566578
static struct attribute_group group_rand_en = {
567579
.name = "format",
568580
.attrs = rand_en_attrs,
@@ -574,13 +586,21 @@ static struct attribute_group group_fetch_l3missonly = {
574586
.is_visible = zen4_ibs_extensions_is_visible,
575587
};
576588

589+
static struct attribute_group group_zen4_ibs_extensions = {
590+
.name = "caps",
591+
.attrs = zen4_ibs_extensions_attrs,
592+
.is_visible = zen4_ibs_extensions_is_visible,
593+
};
594+
577595
static const struct attribute_group *fetch_attr_groups[] = {
578596
&group_rand_en,
597+
&empty_caps_group,
579598
NULL,
580599
};
581600

582601
static const struct attribute_group *fetch_attr_update[] = {
583602
&group_fetch_l3missonly,
603+
&group_zen4_ibs_extensions,
584604
NULL,
585605
};
586606

@@ -615,6 +635,7 @@ static struct attribute_group group_op_l3missonly = {
615635
static const struct attribute_group *op_attr_update[] = {
616636
&group_cnt_ctl,
617637
&group_op_l3missonly,
638+
&group_zen4_ibs_extensions,
618639
NULL,
619640
};
620641

0 commit comments

Comments
 (0)