Skip to content

Commit 8290b56

Browse files
harshimogalapalligregkh
authored andcommitted
usb: typec: tipd: Fix dereferencing freeing memory in tps6598x_apply_patch()
release_firmware() already frees fw, fix this my moving release_firmware after the dereference. Fixes: 916b8e5 ("usb: typec: tipd: add error log to provide firmware name and size") Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Reviewed-by: Javier Carrasco <javier.carrasco@wolfvision.net> Link: https://lore.kernel.org/r/20240724162356.992763-1-harshit.m.mogalapalli@oracle.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 5a444be commit 8290b56

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/usb/typec/tipd/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1191,11 +1191,11 @@ static int tps6598x_apply_patch(struct tps6598x *tps)
11911191
dev_info(tps->dev, "Firmware update succeeded\n");
11921192

11931193
release_fw:
1194-
release_firmware(fw);
11951194
if (ret) {
11961195
dev_err(tps->dev, "Failed to write patch %s of %zu bytes\n",
11971196
firmware_name, fw->size);
11981197
}
1198+
release_firmware(fw);
11991199

12001200
return ret;
12011201
};

0 commit comments

Comments
 (0)