Skip to content

Commit 823de40

Browse files
Mani-Sadhasivamkwilczynski
authored andcommitted
PCI: qcom-ep: Treat unknown IRQ events as an error
Sometimes, the Qcom PCIe EP controller can receive some interrupts unknown to the driver, like safety interrupts in newer SoCs. In those cases, if the driver doesn't clear the interrupts, it will end up in an interrupt storm. However, the users will not know about it because the log is treated as a debug message. So let's treat the unknown event log as an error so that it at least makes the user aware, thereby getting fixed eventually. [kwilczynski: commit log] Link: https://lore.kernel.org/linux-pci/20230726152931.18134-1-manivannan.sadhasivam@linaro.org Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
1 parent 06c2afb commit 823de40

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pci/controller/dwc/pcie-qcom-ep.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data)
593593
dw_pcie_ep_linkup(&pci->ep);
594594
pcie_ep->link_status = QCOM_PCIE_EP_LINK_UP;
595595
} else {
596-
dev_dbg(dev, "Received unknown event: %d\n", status);
596+
dev_err(dev, "Received unknown event: %d\n", status);
597597
}
598598

599599
return IRQ_HANDLED;

0 commit comments

Comments
 (0)