Skip to content

Commit 81b233b

Browse files
sukrutbsudeep-holla
authored andcommitted
firmware: arm_scmi: Fix signed error return values handling
Handle signed error return values returned by simple_write_to_buffer(). In case of an error, return the error code. Fixes: 3c3d818 ("firmware: arm_scmi: Add core raw transmission support") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Sukrut Bellary <sukrut.bellary@linux.com> Reviewed-by: Cristian Marussi <cristian.marussi@arm.com> Tested-by: Cristian Marussi <cristian.marussi@arm.com> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/20230718085529.258899-1-sukrut.bellary@linux.com Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
1 parent d05799d commit 81b233b

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

drivers/firmware/arm_scmi/raw_mode.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -818,10 +818,13 @@ static ssize_t scmi_dbg_raw_mode_common_write(struct file *filp,
818818
* before sending it with a single RAW xfer.
819819
*/
820820
if (rd->tx_size < rd->tx_req_size) {
821-
size_t cnt;
821+
ssize_t cnt;
822822

823823
cnt = simple_write_to_buffer(rd->tx.buf, rd->tx.len, ppos,
824824
buf, count);
825+
if (cnt < 0)
826+
return cnt;
827+
825828
rd->tx_size += cnt;
826829
if (cnt < count)
827830
return cnt;

0 commit comments

Comments
 (0)