Skip to content

Commit 8179041

Browse files
zhijianli88martinkpetersen
authored andcommitted
scsi: pm8001: Convert snprintf() to sysfs_emit()
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). > ./drivers/scsi/pm8001/pm8001_ctl.c:883:8-16: WARNING: please use sysfs_emit No functional change intended CC: Jack Wang <jinpu.wang@cloud.ionos.com> CC: James E.J. Bottomley <jejb@linux.ibm.com> CC: Martin K. Petersen <martin.petersen@oracle.com> CC: linux-scsi@vger.kernel.org Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> Link: https://lore.kernel.org/r/20240116045151.3940401-32-lizhijian@fujitsu.com Acked-by: Jack Wang <jinpu.wang@ionos.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 5fbf37e commit 8179041

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/scsi/pm8001/pm8001_ctl.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -880,9 +880,9 @@ static ssize_t pm8001_show_update_fw(struct device *cdev,
880880
if (pm8001_ha->fw_status != FLASH_IN_PROGRESS)
881881
pm8001_ha->fw_status = FLASH_OK;
882882

883-
return snprintf(buf, PAGE_SIZE, "status=%x %s\n",
884-
flash_error_table[i].err_code,
885-
flash_error_table[i].reason);
883+
return sysfs_emit(buf, "status=%x %s\n",
884+
flash_error_table[i].err_code,
885+
flash_error_table[i].reason);
886886
}
887887
static DEVICE_ATTR(update_fw, S_IRUGO|S_IWUSR|S_IWGRP,
888888
pm8001_show_update_fw, pm8001_store_update_fw);

0 commit comments

Comments
 (0)