Skip to content

Commit 80da96d

Browse files
tiwaiThomas Zimmermann
authored andcommitted
drm/bochs: Fix DPMS regression
The recent rewrite with the use of regular atomic helpers broke the DPMS unblanking on X11. Fix it by moving the call of bochs_hw_blank(false) from CRTC mode_set_nofb() to atomic_enable(). Fixes: 2037174 ("drm/bochs: Use regular atomic helpers") Link: https://bugzilla.suse.com/show_bug.cgi?id=1238209 Signed-off-by: Takashi Iwai <tiwai@suse.de> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://patchwork.freedesktop.org/patch/msgid/20250304134203.20534-1-tiwai@suse.de
1 parent 23e0832 commit 80da96d

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/gpu/drm/tiny/bochs.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,8 +335,6 @@ static void bochs_hw_setmode(struct bochs_device *bochs, struct drm_display_mode
335335
bochs->xres, bochs->yres, bochs->bpp,
336336
bochs->yres_virtual);
337337

338-
bochs_hw_blank(bochs, false);
339-
340338
bochs_dispi_write(bochs, VBE_DISPI_INDEX_ENABLE, 0);
341339
bochs_dispi_write(bochs, VBE_DISPI_INDEX_BPP, bochs->bpp);
342340
bochs_dispi_write(bochs, VBE_DISPI_INDEX_XRES, bochs->xres);
@@ -506,6 +504,9 @@ static int bochs_crtc_helper_atomic_check(struct drm_crtc *crtc,
506504
static void bochs_crtc_helper_atomic_enable(struct drm_crtc *crtc,
507505
struct drm_atomic_state *state)
508506
{
507+
struct bochs_device *bochs = to_bochs_device(crtc->dev);
508+
509+
bochs_hw_blank(bochs, false);
509510
}
510511

511512
static void bochs_crtc_helper_atomic_disable(struct drm_crtc *crtc,

0 commit comments

Comments
 (0)