Skip to content

Commit 805ce81

Browse files
Srinivas-Kandagatlabroonie
authored andcommitted
ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flag
In the current setup the PA is left unmuted even when the Soundwire ports are not started streaming. This can lead to click and pop sounds during start. There is a same issue in the reverse order where in the PA is left unmute even after the data stream is stopped, the time between data stream stopping and port closing is long enough to accumulate DC on the line resulting in Click/Pop noise during end of stream. making use of new mute_unmute_on_trigger flag is helping a lot with this Click/Pop issues reported on this Codec Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Link: https://lore.kernel.org/r/20231027105747.32450-3-srinivas.kandagatla@linaro.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent f022057 commit 805ce81

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

sound/soc/codecs/wsa883x.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1203,9 +1203,6 @@ static int wsa883x_spkr_event(struct snd_soc_dapm_widget *w,
12031203
break;
12041204
}
12051205

1206-
snd_soc_component_write_field(component, WSA883X_DRE_CTL_1,
1207-
WSA883X_DRE_GAIN_EN_MASK,
1208-
WSA883X_DRE_GAIN_FROM_CSR);
12091206
if (wsa883x->port_enable[WSA883X_PORT_COMP])
12101207
snd_soc_component_write_field(component, WSA883X_DRE_CTL_0,
12111208
WSA883X_DRE_OFFSET_MASK,
@@ -1218,9 +1215,6 @@ static int wsa883x_spkr_event(struct snd_soc_dapm_widget *w,
12181215
snd_soc_component_write_field(component, WSA883X_PDM_WD_CTL,
12191216
WSA883X_PDM_EN_MASK,
12201217
WSA883X_PDM_ENABLE);
1221-
snd_soc_component_write_field(component, WSA883X_PA_FSM_CTL,
1222-
WSA883X_GLOBAL_PA_EN_MASK,
1223-
WSA883X_GLOBAL_PA_ENABLE);
12241218

12251219
break;
12261220
case SND_SOC_DAPM_PRE_PMD:
@@ -1346,6 +1340,7 @@ static const struct snd_soc_dai_ops wsa883x_dai_ops = {
13461340
.hw_free = wsa883x_hw_free,
13471341
.mute_stream = wsa883x_digital_mute,
13481342
.set_stream = wsa883x_set_sdw_stream,
1343+
.mute_unmute_on_trigger = true,
13491344
};
13501345

13511346
static struct snd_soc_dai_driver wsa883x_dais[] = {

0 commit comments

Comments
 (0)