Skip to content

Commit 80391d8

Browse files
James-A-ClarkPeter Zijlstra
authored andcommitted
arm_pmu: Remove unused PERF_PMU_CAP_HETEROGENEOUS_CPUS capability
Since commit bd27568 ("perf: Rewrite core context handling") the relationship between perf_event_context and PMUs has changed so that the error scenario that PERF_PMU_CAP_HETEROGENEOUS_CPUS originally silenced no longer exists. Remove the capability and associated comment to avoid confusion that it actually influences any perf core behavior. This change should be a no-op. Signed-off-by: James Clark <james.clark@arm.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com> Acked-by: Ian Rogers <irogers@google.com> Link: https://lore.kernel.org/r/20230724134500.970496-4-james.clark@arm.com
1 parent 4b36873 commit 80391d8

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

drivers/perf/arm_pmu.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -877,15 +877,12 @@ struct arm_pmu *armpmu_alloc(void)
877877
.attr_groups = pmu->attr_groups,
878878
/*
879879
* This is a CPU PMU potentially in a heterogeneous
880-
* configuration (e.g. big.LITTLE). This is not an uncore PMU,
881-
* and we have taken ctx sharing into account (e.g. with our
882-
* pmu::filter callback and pmu::event_init group validation).
883-
*
880+
* configuration (e.g. big.LITTLE) so
884881
* PERF_PMU_CAP_EXTENDED_HW_TYPE is required to open
885882
* PERF_TYPE_HARDWARE and PERF_TYPE_HW_CACHE events on a
886883
* specific PMU.
887884
*/
888-
.capabilities = PERF_PMU_CAP_HETEROGENEOUS_CPUS | PERF_PMU_CAP_EXTENDED_REGS |
885+
.capabilities = PERF_PMU_CAP_EXTENDED_REGS |
889886
PERF_PMU_CAP_EXTENDED_HW_TYPE,
890887
};
891888

0 commit comments

Comments
 (0)