Skip to content

Commit 7ff4fab

Browse files
dlan17linusw
authored andcommitted
pinctrl: spacemit: enable config option
Pinctrl is an essential driver for SpacemiT's SoC, The uart driver requires it, same as sd card driver, so let's enable it by default for this SoC. The CONFIG_PINCTRL_SPACEMIT_K1 isn't enabled when using 'make defconfig' to select kernel configuration options. This result in a broken uart driver where fail at probe() stage due to no pins found. Fixes: a83c29e ("pinctrl: spacemit: add support for SpacemiT K1 SoC") Reported-by: Alex Elder <elder@kernel.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Tested-by: Alex Elder <elder@riscstar.com> Signed-off-by: Yixun Lan <dlan@gentoo.org> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Tested-by: Javier Martinez Canillas <javierm@redhat.com> Link: https://lore.kernel.org/20250218-k1-pinctrl-option-v3-1-36e031e0da1b@gentoo.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent acf40ab commit 7ff4fab

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

arch/riscv/Kconfig.socs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ config ARCH_SOPHGO
2626

2727
config ARCH_SPACEMIT
2828
bool "SpacemiT SoCs"
29+
select PINCTRL
2930
help
3031
This enables support for SpacemiT SoC platform hardware.
3132

drivers/pinctrl/spacemit/Kconfig

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@
44
#
55

66
config PINCTRL_SPACEMIT_K1
7-
tristate "SpacemiT K1 SoC Pinctrl driver"
7+
bool "SpacemiT K1 SoC Pinctrl driver"
88
depends on ARCH_SPACEMIT || COMPILE_TEST
99
depends on OF
10+
default y
1011
select GENERIC_PINCTRL_GROUPS
1112
select GENERIC_PINMUX_FUNCTIONS
1213
select GENERIC_PINCONF

drivers/pinctrl/spacemit/pinctrl-k1.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1044,7 +1044,7 @@ static struct platform_driver k1_pinctrl_driver = {
10441044
.of_match_table = k1_pinctrl_ids,
10451045
},
10461046
};
1047-
module_platform_driver(k1_pinctrl_driver);
1047+
builtin_platform_driver(k1_pinctrl_driver);
10481048

10491049
MODULE_AUTHOR("Yixun Lan <dlan@gentoo.org>");
10501050
MODULE_DESCRIPTION("Pinctrl driver for the SpacemiT K1 SoC");

0 commit comments

Comments
 (0)