Skip to content

Commit 7ff37d2

Browse files
Yuuoniywilldeacon
authored andcommitted
firmware: psci: Fix refcount leak in psci_dt_init
Fix a reference counter leak in psci_dt_init() where of_node_put(np) was missing after of_find_matching_node_and_match() when np is unavailable. Fixes: d09a001 ("drivers: psci: Allow PSCI node to be disabled") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Gavin Shan <gshan@redhat.com> Acked-by: Mark Rutland <mark.rutland@arm.com> Link: https://lore.kernel.org/r/20250318151712.28763-1-linmq006@gmail.com Signed-off-by: Will Deacon <will@kernel.org>
1 parent 0af2f6b commit 7ff37d2

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/firmware/psci/psci.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -804,8 +804,10 @@ int __init psci_dt_init(void)
804804

805805
np = of_find_matching_node_and_match(NULL, psci_of_match, &matched_np);
806806

807-
if (!np || !of_device_is_available(np))
807+
if (!np || !of_device_is_available(np)) {
808+
of_node_put(np);
808809
return -ENODEV;
810+
}
809811

810812
init_fn = (psci_initcall_t)matched_np->data;
811813
ret = init_fn(np);

0 commit comments

Comments
 (0)