Skip to content

Commit 7ebd00a

Browse files
q2venPaolo Abeni
authored andcommitted
Revert "bridge: Add extack warning when enabling STP in netns."
This reverts commit 56a1603. Since the previous commit, STP works on bridge in netns. # unshare -n # ip link add br0 type bridge # ip link add veth0 type veth peer name veth1 # ip link set veth0 master br0 up [ 50.558135] br0: port 1(veth0) entered blocking state [ 50.558366] br0: port 1(veth0) entered disabled state [ 50.558798] veth0: entered allmulticast mode [ 50.564401] veth0: entered promiscuous mode # ip link set veth1 master br0 up [ 54.215487] br0: port 2(veth1) entered blocking state [ 54.215657] br0: port 2(veth1) entered disabled state [ 54.215848] veth1: entered allmulticast mode [ 54.219577] veth1: entered promiscuous mode # ip link set br0 type bridge stp_state 1 # ip link set br0 up [ 61.960726] br0: port 2(veth1) entered blocking state [ 61.961097] br0: port 2(veth1) entered listening state [ 61.961495] br0: port 1(veth0) entered blocking state [ 61.961653] br0: port 1(veth0) entered listening state [ 63.998835] br0: port 2(veth1) entered blocking state [ 77.437113] br0: port 1(veth0) entered learning state [ 86.653501] br0: received packet on veth0 with own address as source address (addr:6e:0f:e7:6f:5f:5f, vlan:0) [ 92.797095] br0: port 1(veth0) entered forwarding state [ 92.797398] br0: topology change detected, propagating Let's remove the warning. Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent 6631463 commit 7ebd00a

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

net/bridge/br_stp_if.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,6 @@ int br_stp_set_enabled(struct net_bridge *br, unsigned long val,
201201
{
202202
ASSERT_RTNL();
203203

204-
if (!net_eq(dev_net(br->dev), &init_net))
205-
NL_SET_ERR_MSG_MOD(extack, "STP does not work in non-root netns");
206-
207204
if (br_mrp_enabled(br)) {
208205
NL_SET_ERR_MSG_MOD(extack,
209206
"STP can't be enabled if MRP is already enabled");

0 commit comments

Comments
 (0)