Skip to content

Commit 7eaa48e

Browse files
lag-linaromartinkpetersen
authored andcommitted
scsi: 3w-sas: Remove snprintf() from sysfs call-backs and replace with sysfs_emit()
Since snprintf() has the documented, but still rather strange trait of returning the length of the data that *would have been* written to the array if space were available, rather than the arguably more useful length of data *actually* written, it is usually considered wise to use something else instead in order to avoid confusion. In the case of sysfs call-backs, new wrappers exist that do just that. Link: https://lwn.net/Articles/69419/ Link: KSPP#105 Cc: Adam Radford <aradford@gmail.com> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20240111131732.1815560-3-lee@kernel.org Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent a977c81 commit 7eaa48e

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

drivers/scsi/3w-sas.c

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -166,24 +166,24 @@ static ssize_t twl_show_stats(struct device *dev,
166166
ssize_t len;
167167

168168
spin_lock_irqsave(tw_dev->host->host_lock, flags);
169-
len = snprintf(buf, PAGE_SIZE, "3w-sas Driver version: %s\n"
170-
"Current commands posted: %4d\n"
171-
"Max commands posted: %4d\n"
172-
"Last sgl length: %4d\n"
173-
"Max sgl length: %4d\n"
174-
"Last sector count: %4d\n"
175-
"Max sector count: %4d\n"
176-
"SCSI Host Resets: %4d\n"
177-
"AEN's: %4d\n",
178-
TW_DRIVER_VERSION,
179-
tw_dev->posted_request_count,
180-
tw_dev->max_posted_request_count,
181-
tw_dev->sgl_entries,
182-
tw_dev->max_sgl_entries,
183-
tw_dev->sector_count,
184-
tw_dev->max_sector_count,
185-
tw_dev->num_resets,
186-
tw_dev->aen_count);
169+
len = sysfs_emit(buf, "3w-sas Driver version: %s\n"
170+
"Current commands posted: %4d\n"
171+
"Max commands posted: %4d\n"
172+
"Last sgl length: %4d\n"
173+
"Max sgl length: %4d\n"
174+
"Last sector count: %4d\n"
175+
"Max sector count: %4d\n"
176+
"SCSI Host Resets: %4d\n"
177+
"AEN's: %4d\n",
178+
TW_DRIVER_VERSION,
179+
tw_dev->posted_request_count,
180+
tw_dev->max_posted_request_count,
181+
tw_dev->sgl_entries,
182+
tw_dev->max_sgl_entries,
183+
tw_dev->sector_count,
184+
tw_dev->max_sector_count,
185+
tw_dev->num_resets,
186+
tw_dev->aen_count);
187187
spin_unlock_irqrestore(tw_dev->host->host_lock, flags);
188188
return len;
189189
} /* End twl_show_stats() */

0 commit comments

Comments
 (0)