Skip to content

Commit 7bf819a

Browse files
andy-shevpmladek
authored andcommitted
vsnprintf: Mark binary printing functions with __printf() attribute
Binary printf() functions are using printf() type of format, and compiler is not happy about them as is: lib/vsprintf.c:3130:47: error: function ‘vbin_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format] lib/vsprintf.c:3298:33: error: function ‘bstr_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format] Fix the compilation errors by adding __printf() attribute. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Kees Cook <kees@kernel.org> Reviewed-by: Petr Mladek <pmladek@suse.com> Link: https://lore.kernel.org/r/20250321144822.324050-5-andriy.shevchenko@linux.intel.com Signed-off-by: Petr Mladek <pmladek@suse.com>
1 parent 196a062 commit 7bf819a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

include/linux/string.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,8 +336,8 @@ int __sysfs_match_string(const char * const *array, size_t n, const char *s);
336336
#define sysfs_match_string(_a, _s) __sysfs_match_string(_a, ARRAY_SIZE(_a), _s)
337337

338338
#ifdef CONFIG_BINARY_PRINTF
339-
int vbin_printf(u32 *bin_buf, size_t size, const char *fmt, va_list args);
340-
int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf);
339+
__printf(3, 0) int vbin_printf(u32 *bin_buf, size_t size, const char *fmt, va_list args);
340+
__printf(3, 0) int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf);
341341
#endif
342342

343343
extern ssize_t memory_read_from_buffer(void *to, size_t count, loff_t *ppos,

0 commit comments

Comments
 (0)