Skip to content

Commit 7bf2e4d

Browse files
Dan Carpenterrafaeljw
authored andcommitted
ACPI: pfr_telemetry: Fix info leak in pfrt_log_ioctl()
The "data_info" struct is copied to the user. It has a 4 byte struct hole after the last struct member so we need to memset that to avoid copying uninitialized stack data to the user. Fixes: b0013e0 ("ACPI: Introduce Platform Firmware Runtime Telemetry driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 31834aa commit 7bf2e4d

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/acpi/pfr_telemetry.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ static int get_pfrt_log_data_info(struct pfrt_log_data_info *data_info,
8383
union acpi_object *out_obj, in_obj, in_buf;
8484
int ret = -EBUSY;
8585

86+
memset(data_info, 0, sizeof(*data_info));
8687
memset(&in_obj, 0, sizeof(in_obj));
8788
memset(&in_buf, 0, sizeof(in_buf));
8889
in_obj.type = ACPI_TYPE_PACKAGE;

0 commit comments

Comments
 (0)