Skip to content

Commit 7ab681d

Browse files
M-Vaittinenbroonie
authored andcommitted
regulator: irq_helpers: duplicate IRQ name
The regulator IRQ helper requires caller to provide pointer to IRQ name which is kept in memory by caller. All other data passed to the helper in the regulator_irq_desc structure is copied. This can cause some confusion and unnecessary complexity. Make the regulator_irq_helper() to copy also the provided IRQ name information so caller can discard the name after the call to regulator_irq_helper() completes. Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> Link: https://msgid.link/r/ZhJMuUYwaZbBXFGP@drtxq0yyyyyyyyyyyyydy-3.rev.dnainternet.fi Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent fec50db commit 7ab681d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/regulator/irq_helpers.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,6 +352,9 @@ void *regulator_irq_helper(struct device *dev,
352352

353353
h->irq = irq;
354354
h->desc = *d;
355+
h->desc.name = devm_kstrdup(dev, d->name, GFP_KERNEL);
356+
if (!h->desc.name)
357+
return ERR_PTR(-ENOMEM);
355358

356359
ret = init_rdev_state(dev, h, rdev, common_errs, per_rdev_errs,
357360
rdev_amount);

0 commit comments

Comments
 (0)