Skip to content

Commit 79c8651

Browse files
f0rm2l1nmstsirkin
authored andcommitted
vdpa: Add features attr to vdpa_nl_policy for nlattr length check
The vdpa_nl_policy structure is used to validate the nlattr when parsing the incoming nlmsg. It will ensure the attribute being described produces a valid nlattr pointer in info->attrs before entering into each handler in vdpa_nl_ops. That is to say, the missing part in vdpa_nl_policy may lead to illegal nlattr after parsing, which could lead to OOB read just like CVE-2023-3773. This patch adds the missing nla_policy for vdpa features attr to avoid such bugs. Fixes: 90fea5a ("vdpa: device feature provisioning") Signed-off-by: Lin Ma <linma@zju.edu.cn> Cc: stable@vger.kernel.org Message-Id: <20230727175757.73988-3-dtatulea@nvidia.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
1 parent 13f3efa commit 79c8651

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/vdpa/vdpa.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1249,6 +1249,7 @@ static const struct nla_policy vdpa_nl_policy[VDPA_ATTR_MAX + 1] = {
12491249
[VDPA_ATTR_DEV_NET_CFG_MACADDR] = NLA_POLICY_ETH_ADDR,
12501250
/* virtio spec 1.1 section 5.1.4.1 for valid MTU range */
12511251
[VDPA_ATTR_DEV_NET_CFG_MTU] = NLA_POLICY_MIN(NLA_U16, 68),
1252+
[VDPA_ATTR_DEV_FEATURES] = { .type = NLA_U64 },
12521253
};
12531254

12541255
static const struct genl_ops vdpa_nl_ops[] = {

0 commit comments

Comments
 (0)