Skip to content

Commit 78a5acf

Browse files
cristiccmripard
authored andcommitted
drm/display: hdmi: Do not read EDID on disconnected connectors
The recently introduced hotplug event handler in the HDMI Connector framework attempts to unconditionally read the EDID data, leading to a bunch of non-harmful, yet quite annoying DDC/I2C related errors being reported. Ensure the operation is done only for connectors having the status connected or unknown. Additionally, perform an explicit reset of the connector information when dealing with a disconnected status. Fixes: ab716b7 ("drm/display/hdmi: implement hotplug functions") Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250113-hdmi-conn-edid-read-fix-v2-1-d2a0438a44ab@collabora.com Signed-off-by: Maxime Ripard <mripard@kernel.org>
1 parent e12b9dc commit 78a5acf

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/gpu/drm/display/drm_hdmi_state_helper.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -791,6 +791,8 @@ drm_atomic_helper_connector_hdmi_update(struct drm_connector *connector,
791791
if (status == connector_status_disconnected) {
792792
// TODO: also handle CEC and scramber, HDMI sink disconnected.
793793
drm_connector_hdmi_audio_plugged_notify(connector, false);
794+
drm_edid_connector_update(connector, NULL);
795+
return;
794796
}
795797

796798
if (connector->hdmi.funcs->read_edid)

0 commit comments

Comments
 (0)