Skip to content

Commit 785c009

Browse files
Yang Lijwrdegoede
authored andcommitted
platform/x86/amd/pmf: Fix unsigned comparison with less than zero
The return value from the call to amd_pmf_get_pprof_modes() is int. However, the return value is being assigned to an unsigned char variable 'mode', so making 'mode' an int. silence the warning: ./drivers/platform/x86/amd/pmf/sps.c:183:5-9: WARNING: Unsigned expression compared with zero: mode < 0 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5995 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Link: https://lore.kernel.org/r/20230727014315.51375-1-yang.lee@linux.alibaba.com Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
1 parent c217337 commit 785c009

File tree

1 file changed

+2
-1
lines changed
  • drivers/platform/x86/amd/pmf

1 file changed

+2
-1
lines changed

drivers/platform/x86/amd/pmf/sps.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,8 @@ int amd_pmf_get_pprof_modes(struct amd_pmf_dev *pmf)
176176

177177
int amd_pmf_power_slider_update_event(struct amd_pmf_dev *dev)
178178
{
179-
u8 mode, flag = 0;
179+
u8 flag = 0;
180+
int mode;
180181
int src;
181182

182183
mode = amd_pmf_get_pprof_modes(dev);

0 commit comments

Comments
 (0)