Skip to content

Commit 774e344

Browse files
Dan Carpenterlinusw
authored andcommitted
pinctrl: bcm281xx: Add missing assignment in bcm21664_pinctrl_lock_all()
The next line checks if this regmap_write() failed, but it doesn't work because the assignment was accidentally left out. Add the assignment. Fixes: 60d6976 ("pinctrl: bcm281xx: Add support for BCM21664 pinmux") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Acked-by: Artur Weber <aweber.kernel@gmail.com> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> Link: https://lore.kernel.org/dfc15d59-7fa9-4f96-aacb-37c3df6d420d@stanley.mountain Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 465cf67 commit 774e344

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/pinctrl/bcm/pinctrl-bcm281xx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1498,8 +1498,8 @@ static int bcm21664_pinctrl_lock_all(struct bcm281xx_pinctrl_data *pdata)
14981498
rc);
14991499
return rc;
15001500
}
1501-
regmap_write(pdata->regmap, BCM21664_ACCESS_LOCK_OFFSET(i),
1502-
0xffffffff);
1501+
rc = regmap_write(pdata->regmap, BCM21664_ACCESS_LOCK_OFFSET(i),
1502+
0xffffffff);
15031503
if (rc) {
15041504
dev_err(pdata->dev, "Failed to write access lock: %d\n",
15051505
rc);

0 commit comments

Comments
 (0)